Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3570 by alexey.n...@gmail.com: RB 2.0.7 shows 'error 500' when displaying the list of recent commits in SVN
https://code.google.com/p/reviewboard/issues/detail?id=3570

Subversion has a feature that it does not expose svn:log property if the user does not have permissions to see *all* paths affected by a commit.

When RB attempts to fetch a list of recent commits on trunk/branch and encounters such commit, it displays an "HTTP 500 INTERNAL SERVER ERROR" message instead of any commits - with a traceback pointing to a KeyError while dereferencing commit['message'].

An obvious stop-gap fix would be to replace commit['message'] in get_commits() in scmtools/svn/__init__.py with commit.get('message', '** log message cannot be retrieved **').

With that fix, the list of commits is displayed successfully. However, an attempt to create a review request based on such partially visible commit creates a request without any diff - not even including the visible paths.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to