Labels: Type-Defect Priority-Medium
New issue 3618 by ke...@keithmoyer.com: Unprintable characters in change
description causes page to crash
What version are you running?
2.0.2 (still present in 2.1 alpha 0)
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1. Create a review request
3. Create a new revision, changing the description or summary to include
What is the expected output? What do you see instead?
I expect to see the page, not showing unprintable characters (or showing
them specially). Instead, the whole review is inaccessible with a 500
I was able to reproduce this on the demo.reviewboard.org site with the
following command for the second revision (the "%0C" is what causes the
curl -X PUT -H "Authorization: Basic $(printf guest9121:demo | openssl
When I do this on my server, the following shows up in the error logs.
2014-10-13 20:42:20,334 - ERROR - - Exception thrown for user <redacted>
not well-formed (invalid token): line 1, column 28
Traceback (most recent call last):
line 112, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
line 23, in _check
return view_func(*args, **kwargs)
line 35, in _check
return view_func(request, local_site=local_site, *args, **kwargs)
line 662, in review_detail
line 159, in get_change_entry_sections_html
line 486, in render_change_entry_html
old_lines = list(iter_markdown_lines(old_value))
line 131, in iter_markdown_lines
nodes = get_markdown_element_tree(markdown_html)
line 184, in get_markdown_element_tree
doc = parseString(b'<html>%s</html>' % markdown_html)
File "/usr/local/lib/python2.7/xml/dom/minidom.py", line 1928, in
File "/usr/local/lib/python2.7/xml/dom/expatbuilder.py", line 940, in
File "/usr/local/lib/python2.7/xml/dom/expatbuilder.py", line 223, in
ExpatError: not well-formed (invalid token): line 1, column 28
What operating system are you using? What browser?
Windows 7, Firefox
Please provide any additional information below.
The unprintable characters were due to a problem in one of my scripts
(people had doxygen comments like "\brief" in their description, and the
script passed it through "echo -ne" at one point).
The unprintable characters are handled fine in the review normally (not
displayed in the description, shows up as a colored dot when editing), but
as soon as it shows up in a change description, it's toast.
I can understand this is a "don't do that" situation, but it would be good
if it was hardened to show _something_ besides a 505 page.
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
You received this message because you are subscribed to the Google Groups
To unsubscribe from this group and stop receiving emails from it, send an email
To post to this group, send email to email@example.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.