Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3637 by [email protected]:
RB.ReviewRequestEditor.setDraftField() unhandled error during error handling
https://code.google.com/p/reviewboard/issues/detail?id=3637
What version are you running?
2.0.10
What's the URL of the page containing the problem?
It's from a custom extension. But I'm pretty sure it's a bug in core.
What steps will reproduce the problem?
1. Call into RB.ReviewRequestEditor.setDraftField()
2. Raise a PublishError from the resource handler
What is the expected output? What do you see instead?
The error appears to be during the error handling in setDraftField() at
https://github.com/reviewboard/reviewboard/blob/9b6f5a7dca96d27d7296cada55bd5609c8b10943/reviewboard/static/rb/js/models/reviewRequestEditorModel.js#L148.
The JSON response has a .stat and .err property, but not .fields. Accessing
the undefined property raises an uncaught TypeError and we lose the
callback chain.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
