Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3657 by thom.ger...@gmail.com: Clicking OK on draft reply to body_top or body_bottom that is blank deletes entire review draft
https://code.google.com/p/reviewboard/issues/detail?id=3657

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?

2.0.11


What's the URL of the page containing the problem?

/r/#####

What steps will reproduce the problem?
1. Create a Review Request Lets use http://demo.reviewboard.org/r/2/ as an example. Publish it. 2. Post a Review to the request that has a body_top, and several diff comments, and a body bottom. For example: http://demo.reviewboard.org/r/2/#review221 . Publish it.
3. Create a draft to this review:
  3a. Add a comment to the header, enter some text, click ok.
  3b. Add a comment to the file, enter some text, click ok.
3c. Add a comment to the footer. Don't enter any text, click OK with it blank.

What is the expected output? What do you see instead?

Actual:  The comment for the header and file is deleted and lost for good.


Expected: The draft is still in tact with the comments on the header and on the file. Or in other words, the only way to discard a draft from the UI should be by clicking the discard button. This hidden discard by submitting a blank comment feature is bound to lose user data accidentally.




What operating system are you using? What browser?

Any.

Please provide any additional information below.


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to