Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3672 by If "0C"(in HEX) character in diff file, what been uploaded, then RB change it to newline, and its crashes the viewdiff

What version are you running?

What's the URL of the page containing the problem?
It's an internal page, i can't link it.

What steps will reproduce the problem?
1. A reviewrequest exists
2. Upload a new diff within the special character  ("0C" in HEX)
3. In diffview, the file not showing

What is the expected output? What do you see instead?
The expected output is to show the difference in viewdiff.

What operating system are you using? What browser?
Windows 7, Firefox/Chrome/IE8

Please provide any additional information below.
In the diff file what we uploading contains the special character ("0C" in HEX) but when we download from RB it contains a new line where the special character was, and its corrupt the diff patch file.

In the RB's error dump (/tmp/reviewboard.ABC123/thefiles.diff), the special character also replaced to a new line character

In the file we upload:
+/***********/

In the file we can download:

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to