Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3704 by sourto...@gmail.com: Google Chrome policies prevent diffs from being downloaded in some cases
https://code.google.com/p/reviewboard/issues/detail?id=3704

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.0.11

What's the URL of the page containing the problem?
https://git.reviewboard.kde.org/r/121338/

What steps will reproduce the problem?
1. Attempt to download the diff in Google Chrome (v16 or later)
2. Get a "Multiple Content-Disposition" error page from Chrome.
3.

What is the expected output? What do you see instead?
The diff.

What operating system are you using? What browser?
Any OS. Browser is Google Chrome.

Please provide any additional information below.

All other browsers and utilities are unaffected.

Caused by Google Chrome policies - https://code.google.com/p/chromium/issues/detail?id=108188

The fix is to edit reviewboard/reviews/views.py, and insert the
following just below line 949.

    filename = filename.replace(',', '_')

Only occurs if the diff name is based upon the summary, and it contains a comma.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to