Status: Accepted
Owner: ----
Labels: Type-Enhancement Priority-Medium

New issue 3731 by mike.d.c...@gmail.com: Make it possible to selectively activate and deactivate ExtensionHooks
https://code.google.com/p/reviewboard/issues/detail?id=3731

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this enhancement request!


What version are you running?

2.0.12


What's the URL of the page this enhancement relates to, if any?

N/A

Describe the enhancement and the motivation for it.

We have a rather complicated extension, and there are bits of it that we'll be able to turn on and off in the configuration page for the extension. It'd be nice if we could make it simple to take a series of ExtensionHooks and disable them, and then re-enable them when later. Right now, I believe if an ExtensionHook has had shutdown called on it before an extension shuts down, the hook will not be removed from the Extension's hook set. If the Extension shuts down, it will attempt to shutdown an already shutdown ExtensionHook, and I believe that will cause an assertion failure (shutdown asserts that self.initialized is True).

There's also not a great way to turn the ExtensionHook back on once shutdown.


What operating system are you using? What browser?

OS X 10.9, Firefox 38


Please provide any additional information below.



--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to