Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3734 by mrcote: review reply diff_comment URI template eclipses review diff_comment URI template in RBClient

What version are you running?


What's the URL of the page containing the problem?

It's a problem with the RBClient package when calling root.get_diff_comments().

What steps will reproduce the problem?
1. Create a review request.
2. Create a review on that review request and open an issue.
3. Use RBClient to try to get the diff_comment for that review in order to get the issue_open_count via root.get_diff_comments().

What is the expected output? What do you see instead?

I should only have to provide review_request_id and review_id in order to get to the diff_comment.

Instead, I get

ValueError: Template was not provided a value for 'reply_id'

smacleod says this is because there are diff_comment resources for both reviews and review replies, and that there is only a URI template created for the latter. So there is no direct way to get to the review's diff_comment; instead, I have to get the review and then call get_diff_comments() on the review resource.

What operating system are you using? What browser?

OS X, Python 2.7.9.

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to