Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3742 by ricktrud...@gmail.com: File missing in View Diff list
https://code.google.com/p/reviewboard/issues/detail?id=3742


What version are you running?
1.7.4

What's the URL of the page containing the problem?
Any review.

What steps will reproduce the problem?
1. Create review with Diff file listed below. It's a simple whitespace change.
2. View the review and go to "View Diff"


What is the expected output? What do you see instead?
Expect that the file contained in the diff will be listed. Instead, no file is listed.


What operating system are you using? What browser?
Linux RedHat, Chrome

Please provide any additional information below.

Here's the diff that was used to reproduce this problem. In this case, the diff contains a simple whitespace change within and XML type comment. I've checked that if the whitespace change is outside the XML comment, the file is properly listed in RB. I've checked that if the file contains other changes (white-space or not) in addition to this change the file is also properly listed in RB.

<BEGIN DIFF>
Index: ./v1_0_0/xmlim/behavior/serviceSas.xml
===================================================================
RCS file: nms_nodes/sros/7210m/v1_0_0/xmlim/behavior/Attic/serviceSas.xml,v
retrieving revision 1.6.80.1
diff -u -r1.6.80.1 serviceSas.xml
--- ./v1_0_0/xmlim/behavior/serviceSas.xml 27 Jan 2015 19:17:01 -0000 1.6.80.1
+++ ./v1_0_0/xmlim/behavior/serviceSas.xml      28 Jan 2015 16:23:38 -0000
@@ -32,7 +32,7 @@
<validation errorKey="sas_cpeping_interval_controlplane">
                                 <!--
                                 throw the error  if
- ! ( !controlplane || (controlplane&& pcaketInterval>4) ) + ! ( !controlplane || (controlplane&& pcaketInterval>4) )
                                 -->
                                 <or>
<equality name="sendViaControlPlane" value="false"/>
<END DIFF>

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to