Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3781 by Problem generating diff files containing UNICODE characters (Fix in description)

*** You must complete this form in its entirety, or your bug report will be
*** rejected.
*** If you have a security issue to report, please send it confidentially
*** Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
*** For customer support, please post to
*** If you have a patch, please submit it to
*** This bug tracker is public. Please check that any logs or other
*** that you include has been stripped of confidential information.

What version are you running?
RBTools 0.7.1 with Python 2.7

What's the URL of the page containing the problem?
None, problem lies in RBTools while generating a diff

What steps will reproduce the problem?
1. Have a file encoded in something else than ASCII
2. try to generate a diff using RBTools
3. It will fail with a message stating the 'ascii' converter cannot process a character > 128

What is the expected output? What do you see instead?
Expected output, a valid diff

What operating system are you using? What browser?
Windows 7, Chrome

Please provide any additional information below.
Here's the culprit:

Line 93

       logging.debug('Command exited with rc %s: %s\n%s---'
                      % (rc, command, data))

It is logging what was read from the file "data" which can be encoded in UNICODE. The logging fails and the whole diff file fails because of it.

Commenting out the logging statement successfully generates a diff. Logging should probably be moved AFTER the conversion of the variable data in ASCII

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to