Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3790 by der.se...@gmail.com: RB not able to open local git repo on Windows
https://code.google.com/p/reviewboard/issues/detail?id=3790

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.0.13

What's the URL of the page containing the problem?
http://blub/reviewboard/admin/db/scmtools/repository/70/

What steps will reproduce the problem?
1. Set a repo name
2. Set repo type Git
3. Set path: file://D:/git_clones/some_repo/.git
4. Click save

What is the expected output? What do you see instead?
RB Repo is created

instead
Error message
Permission denied accessing the local Git repository '/git_clones/some_repo/.git'

What operating system are you using? What browser?
Windows

Please provide any additional information below.
As you can see the hard drive letter is missing from the path

There is already a stackoverflow entry offering a fix
http://stackoverflow.com/questions/6107439/setting-up-a-git-repository-under-review-board-on-windows-server-2003

I'm not sure if this fix is platform independent.
Therefore, I'm proposing platform dependent solution in line 485:

if platform.system() == "Windows":
    #Windows requires drive letter (e.g. C:/)
    self.git_dir = url_parts[1] + url_parts[2]
else:
    self.git_dir = url_parts[2]


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to