Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium
New issue 3834 by dumont....@gmail.com: Support SlikSVN version on Windows
environment
https://code.google.com/p/reviewboard/issues/detail?id=3834
*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this enhancement request!
What version are you running?
RBTools 0.7.2
What's the URL of the page this enhancement relates to, if any?
svn.py
Describe the enhancement and the motivation for it.
We want to use RBTools on our environnement, for post commit reviews, but
it fails to recognise our SVN version as the command 'svn --version -q'
returns : 1.6.1-SlikSvn-tag-1.6.1@37143-X64
What operating system are you using? What browser?
OS : Windows 7
SVN version : SlikSvn:tag/1.6.1@37143.
Please provide any additional information below.
The script which fails is svn.py. Currently, the command is :
ver_string = self._run_svn(['--version', '-q'], ignore_errors=True)
self.subversion_client_version = tuple(map(int, ver_string.split('.')))
This will try to convert '1.6.1-SlikSvn-tag-1.6.1' as an integer, and fails.
I have modified my script as this to work :
ver_string = self._run_svn(['--version', '-q'], ignore_errors=True)
ver_string_splitted = ver_string.split('-')
self.subversion_client_version = tuple(map(int,
ver_string_splitted[0].split('.')))
I have not push a patch as I'm not sure that it's the best solution ...
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
