Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3841 by yaneurab...@gmail.com: rbtools.api.request hardcodes http return codes
https://code.google.com/p/reviewboard/issues/detail?id=3841

Version

0.7.2

Note: this is based purely on code inspection. These numbers should be derived from the httplib module, not hardcoded in the code.

196 class ReviewBoardHTTPErrorProcessor(HTTPErrorProcessor):
197     """Processes HTTP error codes.
198
199 Python 2.6 gets HTTP error code processing right, but 2.4 and 2.5 only
200     accepts HTTP 200 and 206 as success codes. This handler ensures that
201     anything in the 200 range, as well as 304, is a success.
202     """
203     def http_response(self, request, response):
204         if not (200 <= response.code < 300 or response.code == 304):
205             response = self.parent.error('http', request, response,
206                                          response.code, response.msg,
207                                          response.info())
208
209         return response

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to