Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium

New issue 3863 by csipak.a...@ardinsys.eu: Web API should provide an id field for a review request's every depends_on entry
https://code.google.com/p/reviewboard/issues/detail?id=3863

What version are you running?

2.0.15

What's the URL of the page this enhancement relates to, if any?

http://demo.reviewboard.org/api/review-requests/

Describe the enhancement and the motivation for it.

Currently if I query review requests either via review_requests or review_requests/<review_request_id> Web API resource, depends_on data appears in the response like this:

"depends_on": [         {
   "href": "http://adsrv2/reviewboard/api/review-requests/51/";,
   "method": "GET",
   "title": "blah-blah-blah"
}],

If I want to query a review request's depends_on ids, I can:

a) Implement a hack, and use substring on the href field. This is not only unelegant, but also violates a principle stated in the first chapter of the Web API documentation (https://www.reviewboard.org/docs/manual/2.0/webapi/2.0/overview/#resource-urls).

b) Launch another GET request using the href field, and get the id from the response. Suppose my review requests has got two dozen depends_on references, I will have to do two dozen separate calls to get a couple of characters worth of result per response payload. Not really elegant, nor efficient.

There should be an id field within every depends_on element. Example:

"depends_on": [         {
   "id": "51",
   "href": "http://adsrv2/reviewboard/api/review-requests/51/";,
   "method": "GET",
   "title": "blah-blah-blah"
}],


What operating system are you using? What browser?

Windows 7
Firefox

Please provide any additional information below.


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to