Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3866 by [email protected]: mxml source file patches fail to
get applied
https://code.google.com/p/reviewboard/issues/detail?id=3866
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** [email protected]. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to [email protected]
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
1.6.6
What's the URL of the page containing the problem?
'View diff' for an mxml source file
What steps will reproduce the problem?
1. Make changes to an mxml source file (Flex Application)
2. Post the changes for review to reviewboard
3. The following error trace is observed:
Diff currently unavailable.
Error: The patch
to '//projects/flash-client-dev/hdcore/v3.8/support-players/ZoroDebugPlayer/src/ZoroDebugPlayer.mxml'
didn't apply cleanly. The temporary files have been left
in '/tmp/reviewboard.Mwxe1l' for debugging purposes. `patch` returned:
patching file /tmp/reviewboard.Mwxe1l/tmpKE4shz patch: **** malformed patch
at line 5: <s:Application xmlns:fx="http://ns.adobe.com/mxml/2009";
Details
Traceback (most recent call last):
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/views.py",
line 217, in view_diff_fragment
file = get_requested_diff_file()
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/views.py",
line 193, in get_requested_diff_file
get_chunks)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/diffutils.py",
line 1072, in get_diff_files
large_data=True)
File "/usr/local/lib/python2.6/dist-packages/Djblets-0.6.16-py2.6.egg/djblets/util/misc.py",
line 157, in cache_memoize
data = lookup_callable()
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/diffutils.py",
line 1071, in <lambda>
enable_syntax_highlighting)),
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/diffutils.py",
line 553, in get_chunks
new = get_patched_file(old, filediff)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/diffutils.py",
line 375, in get_patched_file
return patch(filediff.diff, buffer, filediff.dest_file)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.6-py2.6.egg/reviewboard/diffviewer/diffutils.py",
line 243, in patch
(filename, tempdir, patch_output))
Exception: The patch
to '//projects/flash-client-dev/hdcore/v3.8/support-players/ZoroDebugPlayer/src/ZoroDebugPlayer.mxml'
didn't apply cleanly. The temporary files have been left
in '/tmp/reviewboard.Mwxe1l' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.Mwxe1l/tmpKE4shz
patch: **** malformed patch at line 5: <s:Application
xmlns:fx="http://ns.adobe.com/mxml/2009";
What is the expected output? What do you see instead?
I should see the diff of the new commit vs. the previous commit
What operating system are you using? What browser?
Mac OS X 10.10.3 on Chrome 42. Also Safari 8.0.5.
Please provide any additional information below.
Here is the opening line causing the problem:
<s:Application xmlns:fx="http://ns.adobe.com/mxml/2009";
xmlns:s="library://ns.adobe.com/flex/spark"
xmlns:mx="library://ns.adobe.com/flex/mx"
xmlns:metadata="org.osmf.metadata.*"
xmlns:local="*"
width="100%" height="100%" applicationComplete="init()"
backgroundAlpha="0"
backgroundColor="#444242" currentState="videotracestats"
preloaderChromeColor="#BBBBBB"
stateChangeComplete="startDelayedResize()" >
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
