Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3887 by erik.l...@gmail.com: Perforce diff submission is broken
in 2.0.17
https://code.google.com/p/reviewboard/issues/detail?id=3887
What version are you running?
ReviewBoard 2.0.17 and RBTools 0.7.2 and 0.7.4
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1. Attempt to post any change via perforce
What is the expected output? What do you see instead?
I expect the post to succeed. Instead, I get a 500 error in the client:
Generating diff for pending changeset 179888
ERROR: Error validating diff
HTTP 500
And the error in the server is:
[...]
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/webapi/resources/validate_diff.py",
line 144, in create
save=False)
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/diffviewer/managers.py",
line 156, in create_from_upload
save=save)
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/diffviewer/managers.py",
line 180, in create_from_data
check_existence=(not parent_diff_file_contents)))
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/diffviewer/managers.py",
line 287, in _process_files
copied=f.copied)
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/scmtools/perforce.py",
line 332, in parse_diff_revision
filename, revision = revision_str.rsplit('#', 1)
ValueError: need more than 1 value to unpack
What operating system are you using? What browser?
N/A
Please provide any additional information below.
Looking at revision_str, it doesn't contain any '#' character and is
actually of the form: "2015-06-16 11:39:35" when called with f.newFile and
f.newInfo. When called with f.origFile and f.origInfo,
parse_diff_revision() would work as expected but we bomb out before getting
there.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
