Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3894 by [email protected]: When using mercurial empty
files are included in all posted reviews
https://code.google.com/p/reviewboard/issues/detail?id=3894
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** [email protected]. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to [email protected]
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
RBTools 0.7.3
What's the URL of the page containing the problem?
http://reviews.internal
What steps will reproduce the problem?
1. Create a mercurial repository with three committed files, fileA, fileB,
and fileC. fileA and fileB must have some content, fileC must be empty.
2. Remove fileA. Edit contents of fileB.
3. rbt post
What is the expected output? What do you see instead?
I expected the posted review to only contain fileA and fileB. The posted
review contains fileC as well.
What operating system are you using? What browser?
Windows 7, Mercurial 3.4.1
Please provide any additional information below.
The problem is RBT tries to locate newly added empty files by running two
commands:
base_files = hg locate -r base
tip_empty_files = hg locate -r tip set:size(0)
newly_added_empty_files = tip_empty_files - base_files
In Windows hg locate -r base returns the following:
folder1/subfolder1/fileA.txt
folder2/subfolder2/fileB.txt
folder1/subfolder3/fileC.txt
where as hg locate -r tip set:size(0) returns:
folder1\subfolder3\fileC.txt
Note that the first command uses a forward slash as path separator, the
second uses backslash as path separator. When calculating the set
difference fileC.txt doesn't match and rbt posts it as a newly added file.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
