Labels: Type-Defect Priority-Medium
New issue 3910 by ronald.c...@visiercorp.com: rbt post fails when parent
has empty files and currently in subdirectory using mercurial
*** READ THIS BEFORE POSTING!
*** You must complete this form in its entirety, or your bug report will be
*** If you have a security issue to report, please send it confidentially
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
*** This bug tracker is public. Please check that any logs or other
*** that you include has been stripped of confidential information.
What version are you running?
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1. Create a mercurial repository with three committed files, fileA, fileB,
and fileC. fileA and fileB must have some content, fileC must be empty.
2. Remove fileA. Edit contents of fileB.
3. Create a sub directory and go into it
4. rbt post
What is the expected output? What do you see instead?
I expected the posted review to only contain fileA and fileB. The posted
review contains fileC as well.
What operating system are you using? What browser?
Mac OS X, Mercurial 3.4.1
Please provide any additional information below.
The problem is RBT tries to locate newly added empty files by running two
base_files = hg locate -r base
tip_empty_files = hg locate -r tip set:size(0)
newly_added_empty_files = tip_empty_files - base_files
hg locate -r base returns the following:
where as hg locate -r tip set:size(0) returns:
Note that the first command uses a path relative to the root of the
repository, the second uses a path relative to the current directory. When
calculating the set difference fileC.txt doesn't match and rbt posts it as
a newly added file.
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
You received this message because you are subscribed to the Google Groups
To unsubscribe from this group and stop receiving emails from it, send an email
To post to this group, send email to email@example.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.