Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3946 by pde...@gmail.com: Add styling for .codehilite to signify the section
https://code.google.com/p/reviewboard/issues/detail?id=3946

What version are you running?

2.0.18 (but also in 2.5 beta 3)

What's the URL of the page containing the problem?

http://demo.reviewboard.org/r/3/

What steps will reproduce the problem?

1. Publish a comment with a fenced code block (```).
2. View the comment

What is the expected output? What do you see instead?

The div with class 'codehilite' appears inline with the rest of the human message. It doesn't particularly stand out, outside a left margin.

What operating system are you using? What browser?

Windows, Chrome stable

Please provide any additional information below.

It is common practice to add borders and background to signify the code block. This is regardless of code syntax styling.

Likely top examples would come from StackOverflow and GitHub.

StackOverflow - light grey background without border
@see http://stackoverflow.com/editing-help#syntax-highlighting

GitHub - light grey background with border
@seee https://guides.github.com/features/mastering-markdown/#examples (click Code)

Personally, I've added the styling to a userscript to handle it on my client, but I think it's common practice enough that the project should support this.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to