Comment #3 on issue 3747 by nano...@gmail.com: Review images is broken
https://code.google.com/p/reviewboard/issues/detail?id=3747

@david,

Is there a chance this issue also affect document (a .docx)?

on our side we've got a 500 error when displaying review request containing an attachement (.docx) after migration from 2.0.15 to 2.0.19, see call stack:

File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/reviews/templatetags/reviewtags.py", line 91, in file_attachment_comments
    file_attachment.get_comments()))

  File "/usr/lib/python2.7/json/__init__.py", line 231, in dumps
    return _default_encoder.encode(obj)

  File "/usr/lib/python2.7/json/encoder.py", line 201, in encode
    chunks = self.iterencode(o, _one_shot=True)

  File "/usr/lib/python2.7/json/encoder.py", line 264, in iterencode
    return _iterencode(o, 0)

  File "/usr/lib/python2.7/json/encoder.py", line 178, in default
    raise TypeError(repr(o) + " is not JSON serializable")

TypeError: <generator object serialize_comments at 0x7f2abe9246e0> is not JSON serializable

if confirmed, I can open another issue.

Regards,

Nicolas

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to