Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3966 by Uploading a revision to a CR twice before publishing creates bad partial diffs

What version are you running?
  Reviewboard 2.0.19 and RBTools 0.7.4 for Windows
  I am using a git repository that is mounted as a directory
  on the reviewboard server.

What's the URL of the page containing the problem?

What steps will reproduce the problem?
  Summary: Upload and publish a CR then upload two move revisions
  before publishing the latter. The 1-2 diff will be incorrect.

  1. Create a code change with a diff (e.g. adding
     a line to a file that reads "Change #1") and run 'rbt post'
  2. Publish the review.
  3. Update the code change (e.g. change the line to
     say "Fake Change #2") and run 'rbt post -u'
  4. On reviewboard, view the diffs orig-1, orig-2 and 1-2,
     and verify that they show diffs between three versions
     of a file with a blank line, 'Change #1' and 'Fake
     Change #2', but DON'T publish.
  5. Update the code change once more (e.g. change the line
     to say 'Real Change #2) and run 'rbt post -u'
  6. On reviewboard, view the diffs once more. Verify that
     orig-2 shows that the line 'Real Change #2' has been
     added. Look at the diff 1-2 and notice that it says
     'Change #1' -> 'Fake Change #2', instead of
     'Change #1' -> 'Real Change #2'.

What is the expected output? What do you see instead?
  Expected output: All diffs accurately represent the difference
  between the respective versions of the code change.

Actual output:
  Diffs between orig and another commit are correct, but relative
  diffs (1-2) are out of date and show non-existent changes.

What operating system are you using? What browser?
  Windows 8.1 Pro 64-bit and latest Google Chrome (Version 45.0.2454.85 m)

Please provide any additional information below.
  It appears that the relative diffs between intermediate revisions
  and the latest revision are being stored at the moment that the latest
  revision is uploaded and not updated when the revision is updated
  prior to publishing it.

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to