------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4371/
------------------------------------------------------------------------------
New update by smacleod
For Beanbag, Inc. > Review Board > Ticket #4371
Reply:
I started to work on this issue.
I've been debugging the example above. It's definitely not finished, but
I've been asked to brain dump what I know for now. The interdiff is reproduced
using steps from above. Lines numbers might be not exact as in code as I've
been adding logging.
Iterating in loop opcode_generator.py line ~394
i_move_cur 6804
<MoveRange(4114, 4186, [((u'delete', 4113, 4322, 4113, 4113,
{u'whitespace_chunk': False, u'whitespace_lines': []}), 1), ((u'delete', 4113,
4322, 4113, 4113, {u'whitespace_chunk': False, u'whitespace_lines': []}), 1),
((u'delete', 4113, 4322, 4113, 4113, {u'whitespace_chunk': False,
u'whitespace_lines': []}), 1), ((u'delete', 4113, 4322, 4113, 4113,
{u'whitespace_chunk': False, u'whitespace_lines': []}), 1), ((u'delete', 4113,
4322, 4113, 4113, {u'whitespace_chunk': False, u'whitespace_lines': []}), 1),
((u'delete', 4113, 4322, 4113, 4113, {u'whitespace_chunk': False,
u'whitespace_lines': []}), 1), ((u'delete', 4113, 4322, 4113, 4113,
{u'whitespace_chunk': False, u'whitespace_lines': []}), 1), ((u'delete', 4113,
4322, 4113, 4113, {u'whitespace_chunk': False, u'whitespace_lines': []}), 1),
((u'delete', 4113, 4322, 4113, 4113, {u'whitespace_chunk': False,
u'whitespace_lines': []}), 1), ((u'delete', 4113, 4322, 4113, 4113,
{u'whitespace_chunk': False, u'whitespace_lines': []}), 1), ((u'delete', 4113,
4322, 4113, 4113, {u'whitespace_chunk': False, u'whitespace_lines': []}), 1),
((u'delete', 4113, 4322, 4113, 4113, {u'whitespace_chunk': False,
u'whitespace_lines': []}), 1), ((u'delete', 4113, 4322, 4113, 4113,
{u'whitespace_chunk': False, u'whitespace_lines': []}), 1), ((u'delete', 4113,
4322, 4113, 4113, {u'whitespace_chunk': False, u'whitespace_lines': []}), 1),
((u'delete', 4113, 4322, 4113, 4113, {u'whitespace_chunk': False,
u'whitespace_lines': []}), 1), ((u'delete', 4113, 4322, 4113, 4113,
{u'whitespace_chunk': False, u'whitespace_lines': []}), 1), ((u'delete', 4113,
4322, 4113, 4113, {u'whitespace_chunk': False, u'whitespace_lines': []}), 1),
((u'delete', 4113, 4322, 4113, 4113, {u’whitesp [...]
i_move_cur 6805, ri 4186 (no changes)
MOVED_TO showed up, 4115: 6732 <---> 4186: 6803
i_move_cur 6812
<MoveRange(4189, 4194, [((u'delete', 4113, 4322, 4113, 4113,
{u'whitespace_chunk': False, u'moved-to': {4115: 6732, 4116: 6733, 4117: 6734,
4118: 6735, 4119: 6736, 4120: 6737, 4121: 6738, 4122: 6739, 4123: 6740, 4124:
6741, 4125: 6742, 4126: 6743, 4127: 6744, 4128: 6745, 4129: 6746, 4130: 6747,
4131: 6748, 4132: 6749, 4133: 6750, 4134: 6751, 4135: 6752, 4136: 6753, 4137:
6754, 4138: 6755, 4139: 6756, 4140: 6757, 4141: 6758, 4142: 6759, 4143: 6760,
4144: 6761, 4145: 6762, 4146: 6763, 4147: 6764, 4148: 6765, 4149: 6766, 4150:
6767, 4151: 6768, 4152: 6769, 4153: 6770, 4154: 6771, 4155: 6772, 4156: 6773,
4157: 6774, 4158: 6775, 4159: 6776, 4160: 6777, 4161: 6778, 4162: 6779, 4163:
6780, 4164: 6781, 4165: 6782, 4166: 6783, 4167: 6784, 4168: 6785, 4169: 6786,
4170: 6787, 4171: 6788, 4172: 6789, 4173: 6790, 4174: 6791, 4175: 6792, 4176:
6793, 4177: 6794, 4178: 6795, 4179: 6796, 4180: 6797, 4181: 6798, 4182: 6799,
4183: 6800, 4184: 6801, 4185: 6802, 4186: 6803}, u'whitespace_lines': []}), 1),
((u'delete', [...]
i_move_cur 6813, ri 4194
i_move_cur 6831
MoveRange(4197, 4213, [((u'delete', 4113, 4322, 4113, 4113,
{u'whitespace_chunk': False, u'moved-to': {4115: 6732, 4116: 6733, 4117: 6734,
4118: 6735, 4119: 6736, 4120: 6737, 4121: 6738, 4122: 6739, 4123: 6740, 4124:
6741, 4125: 6742, 4126: 6743, 4127: 6744, 4128: 6745, 4129: 6746, 4130: 6747,
4131: 6748, 4132: 6749, 4133: 67 [...] (just more numbers)
i_move_cur 6832, ri 4213
i_move_cur 6839
<MoveRange(4216, 4221, [((u'delete', 4113, 4322, 4113, 4113,
{u'whitespace_chunk': False, u'moved-to': {4115: 6732, 4116: 6733, 4117: 6734,
4118: 6735, 4119: 6736, 4120: 6737, 4121: 6738, 4122: 6739, 4123: 6740, 4124:
6741, 4125: 6742, 4126: 6743, 4127: 6744, 4128: 6745, 4129: 6746, 4130: 6747,
4131: 6748, 4132: 6749, 4133: [...] (just more numbers)
i_move_cur 6840
i_move_cur 6847
<MoveRange(4224, 4229, [((u'delete', 4113, 4322, 4113, 4113,
{u'whitespace_chunk': False, u'moved-to': {4115: 6732, 4116: 6733, 4117: 6734,
4118: 6735, 4119: 6736, 4120: 6737, 4121: 6738, 4122: 6739, 4123: 6740, 4124:
6741, 4125: 6742, 4126: 6743, 4127: 6744, 4128: 6745, 4129: 6746, 4130: 6747,
4131: 6748, [...] (just more numbers)
[...]
iline: inherited: false,
going deeper for i_move_cur 6943
For ri == 4306 self.removes for iline got finished
i_move_cur -= 1
i_move_cur += 1
#452
i_move_cur 6943, updated_range False, ij2 6950
"moved-to section" of r_move_range is 4115: 6732 <--> 4321:6938 after
_find_longest_move_range
The same after _determine_move_range
in #491 rmeta is set so MoveRange has line 4115: 6942
This shouldn’t happen as this move is only two lines long and is
overwriting a pretty long one
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
