------------------------------------------------------------------------------ To reply, visit https://hellosplat.com/s/beanbag/tickets/4533/ ------------------------------------------------------------------------------
New ticket #4533 by besperon For Beanbag, Inc. > Review Board Status: New Tags: Priority:Medium, Type:Defect File attachments: * example_not_working.jpg <https://hellosplat.com/s/beanbag/attachments/1232/> * example_working.jpg <https://hellosplat.com/s/beanbag/attachments/1233/> * diffutils.py <https://hellosplat.com/s/beanbag/attachments/1234/> * bugged_interdiffs.tar.bz2 <https://hellosplat.com/s/beanbag/attachments/1235/> ------------------------------------------------------------------------------ Interdiffs are not working on some files ============================================================================== # What version are you running? 2.5.7 Tried 2.5.9 too The problem didn't exist in the 1.7.6 version (appeared after update) # What's the URL of the page containing the problem? /r/[review_id]/diff/[interdiff_id_1]-[interdiff_id_2] # What steps will reproduce the problem? 1. Comparison between two revisions 2. Taking a look at the files often gives me "only whitespace changes" diffs when there are other changes # What is the expected output? What do you see instead? An interdiff showing me the changes, instead I only see whitespace changes. # What operating system are you using? What browser? Server : Suse 11.4. Browser : Firefox / IE11 # Please provide any additional information below. You'll find attached a small git repo with files and diffs that reproduce this precise behaviour, a few screen, and the diffutils.py file that """fixes""" this problem. I successfully """fixed""" this bug by using the 1.7.6 version of the get_chunks function (and the relevant called functions) in diffviewer/diffutils. It is interesting to note I had the exact same behaviour with the 1.7.6 code, and with get_original_file called repository.get_file() without cache_memoize. Sorry for the messy patchwork that diffutils.py is ! I hope that can help you. ------------------------------------------------------------------------------ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
