------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
------------------------------------------------------------------------------

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

    I was able to fix the icon img by adding srcset to the rule for img tags in 
mod_proxy_html:
    ProxyHTMLLinks  img  src srcset
    
    original:
    <img id="logo" src="/rb/static/rb/images/logo.cc81d3ae01b2.png" 
srcset="/static/rb/images/logo.cc81d3ae01b2.png 1x, 
/static/rb/images/l...@2x.4e25cc3cacef.png 2x" alt="" border="0" width="60" 
height="57">
    result:
    <img id="logo" src="/rb/static/rb/images/logo.cc81d3ae01b2.png" 
srcset="/rb/static/rb/images/logo.cc81d3ae01b2.png 1x, 
/static/rb/images/l...@2x.4e25cc3cacef.png 2x" alt="" border="0" width="60" 
height="57">
    
    Although the second url in srcset is not rewritten.
    
    However, the onclick event in list item elements of the page_sidebar is 
quite a bit different.
    
    <li class="item has-url has-count" 
onclick="javascript:window.location=&quot;/dashboard/?view=mine&quot;; return 
false;"><div class="page-sidebar-row"><div class="rb-icon "></div><span 
class="label"><a href="/rb/dashboard/?view=mine">All</a></span><span 
class="count count-zero">0</span></div></li>

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to