------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4638/
------------------------------------------------------------------------------
New update by Misery
For Beanbag, Inc. > Review Board > Ticket #4638
Reply:
Binary patches aren't supported. In Git, they default to not being included
unless `--binary` is passed or an equivalent option is in `.gitconfig` (which
we should turn off). For the new Git diff support in Mercurial, we will need to
determine how to turn this off as well. And in Review Board, we should not
break when encountering a binary diff.
So there's three tasks here, which we'll split up and track internally:
1. `git diff` should be passed some flag to turn off binary files. There
doesn't seem to be an equivalent to `--binary`, though, so we might have to do
something a bit more complex.
2. We should figure out if Mercurial is always generating diffs for binary
files, and see if that behavior can be turned off. Doesn't look like it can, at
first glance, but perhaps?
3. Review Board's Git diff parser should be able to handle the payload for
binary files.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
