------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4683/
------------------------------------------------------------------------------

New ticket #4683 by kyz
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


------------------------------------------------------------------------------
Search doesn't index review requests owned by inactive users
==============================================================================

# What version are you running?
3.0.5

# What's the URL of the page containing the problem?
/reviews/search

# What steps will reproduce the problem?
1. Search for something that appears in the summary of a review request which 
is public and completed or pending review, but is owned by an inactive user

# What is the expected output? What do you see instead?
I'd expect to be able to search for any text in the summary of review requests 
on the All Review Requests page.

The actual output is "No review requests match your query"

# What operating system are you using? What browser?
Ubuntu, Firefox

# Please provide any additional information below.

Applying this patch and updating the index fixes the issue:

--- reviewboard/reviews/search_indexes.py.orig  2018-03-26 18:08:29.313052467 
+0000
+++ reviewboard/reviews/search_indexes.py       2018-03-26 18:08:45.541322304 
+0000
@@ -50,6 +50,7 @@
             .public(status=None,
                     extra_query=Q(status='P') | Q(status='S'),
                     show_all_local_sites=True,
+                    show_inactive=True,
                     filter_private=False)
             .select_related('diffset_history',
                             'local_site',


------------------------------------------------------------------------------

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to