------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4608/
------------------------------------------------------------------------------
New update by theBoss
For Beanbag, Inc. > RBTools > Ticket #4608
Reply:
I am having the same issue. This also highlights a discrepancy in the way
the ReviewBoard displays diffs between `git` and `svn`. In pure `git`, when a
file is moved ReviewBoard (the UI) shows the file one time and marks it as
moved. In `svn`, a moved file will either just show up once and not be marked
as moved, or show up twice and be marked as removed/added. There is an
svn-specific option (`--svn-show-copies-as-adds`) for RBTools that controls
this. When a file is moved and changed it will be even more confusing in
ReviewBoard for `svn`. If `--svn-show-copies-as-adds=y` is used, then two
copies of the file are shown with no diff to show the change, so ReviewBoard is
almost useless for analyzing what changed. If `--svn-show-copies-as-adds=n` is
used then two copies are still shown, but at least once of them shows the
rename and diff - which is great. The other copy that shows the file as deleted
serves no purpose since the file was already marked as moved.
I think the way that ReviewBoard does it for `git` is more intuitive. Just
show the file once and mark that it was moved (with diffs if applicable).
ReviewBoard should behave in the same manner for `git`, `svn`, and `git-svn`.
It would be great if this could be fixed!
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
