------------------------------------------------------------------------------ To reply, visit https://hellosplat.com/s/beanbag/tickets/4825/ ------------------------------------------------------------------------------
New ticket #4825 by alebastr For Beanbag, Inc. > RBTools Status: New Tags: Priority:Medium, Type:Defect ------------------------------------------------------------------------------ rbt diff fails for git-p4 repo with Python 3.7.2 on Windows. ============================================================================== # What version are you running? RBTools 1.0.2 + a32dadb # What steps will reproduce the problem? 1. Install Python 3.7.x and rbtools 1.0.2 on Windows 2. Apply patch from https://github.com/reviewboard/rbtools/commit/a32dadbbd5b071cce5a12128240b9ff6ce7e83a2 3. Clone perforce repo with git-p4 4. Commit some changes 3. Run `rbt diff` # What is the expected output? What do you see instead? Expected: diff output Actual: CRITICAL: cannot use a bytes pattern on a string-like object CRITICAL: can't concat str to bytes CRITICAL: a bytes-like object is required, not 'str' ... # What operating system are you using? Windows 10 x64 # Attach the debug out from the command. ``` PS % rbt diff -d >>> RBTools 1.0.2 >>> Python 3.7.2 (tags/v3.7.2:9a3ffc0492, Dec 23 2018, 23:09:28) [MSC v.1916 64 >>> bit (AMD64)] >>> Running on Windows-10-10.0.16299-SP0 >>> Home = C:\Users\bavshin\AppData\Roaming >>> Current directory = C:\Users\bavshin\Source\Repos\<...> >>> Command line: rbt diff -d >>> Running: tf vc help >>> Checking for a Bazaar repository... >>> Unable to execute "bzr help": skipping Bazaar >>> Checking for a ClearCase repository... >>> Unable to execute "cleartool help": skipping ClearCase >>> Checking for a CVS repository... >>> Unable to execute "cvs": skipping CVS >>> Checking for a Git repository... >>> Running: git rev-parse --git-dir >>> Running: git config core.bare >>> Running: git rev-parse --show-toplevel >>> Running: git symbolic-ref -q HEAD >>> Running: git config --get git-p4.port >>> Repository info: Path: perforce.example.com:1666, Base path: , Supports >>> changesets: False >>> Checking for a Mercurial repository... >>> Running: hg root >>> Command exited with rc 255: ['hg', 'root'] abort: no repository found in 'C:\Users\bavshin\Source\Repos\<...>' (.hg not found)! --- >>> Checking for a Perforce repository... >>> Running: p4 info >>> Checking for a Plastic repository... >>> Unable to execute "cm version": skipping Plastic >>> Checking for a Subversion repository... >>> Unable to execute "svn help": skipping SVN >>> Checking for a Team Foundation Server repository... >>> Unable to execute "tf help": skipping TFS >>> Running: git config --get reviewboard.url >>> Making HTTP GET request to https://reviewboard.example.com/api/ >>> Making HTTP GET request to https://reviewboard.example.com/api/info/ >>> Running: git rev-parse refs/heads/current-branch >>> Running: git branch --remotes >>> Running: git rev-parse p4/master >>> Running: git rev-list 8f934ac10ec3fcba20b9bb4359a7240ce06f3295 --not >>> --remotes=p4 >>> Running: git status --porcelain --untracked-files=no >>> --ignore-submodules=dirty >>> Running: git version >>> Running: git -c core.quotepath=false diff --no-color --no-prefix -r -u >>> --no-ext-diff >>> 8f934ac10ec3fcba20b9bb4359a7240ce06f3295..7c0084ebef48a82a27ac5c23baa6df762e5ef2e5 >>> Running: git log 8f934ac10ec3fcba20b9bb4359a7240ce06f3295 Traceback (most recent call last): File "c:\python3\lib\runpy.py", line 193, in _run_module_as_main "__main__", mod_spec) File "c:\python3\lib\runpy.py", line 85, in _run_code exec(code, run_globals) File "C:\Python3\Scripts\rbt.exe__main__.py", line 9, in <module> File "c:\python3\lib\site-packages\rbtools\commands\main.py", line 120, in main command.run_from_argv([RB_MAIN, command_name] + args) File "c:\python3\lib\site-packages\rbtools\commands__init__.py", line 725, in run_from_argv exit_code = self.main(*args) or 0 File "c:\python3\lib\site-packages\rbtools\commands\diff.py", line 77, in main extra_args=extra_args) File "c:\python3\lib\site-packages\rbtools\clients\git.py", line 636, in diff no_renames) File "c:\python3\lib\site-packages\rbtools\clients\git.py", line 784, in make_diff return self.make_perforce_diff(merge_base, diff_lines) File "c:\python3\lib\site-packages\rbtools\clients\git.py", line 890, in make_perforce_diff log, re.M) File "c:\python3\lib\re.py", line 183, in search return _compile(pattern, flags).search(string) TypeError: cannot use a bytes pattern on a string-like object ``` # Please provide any additional information below. ------------------------------------------------------------------------------ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/reviewboard-issues. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190528204939.32248.42618%40ip-10-1-54-209.ec2.internal. For more options, visit https://groups.google.com/d/optout.
