in the review there is a file: P4Tool.txt. There is one part that you need to edit. Place the location of post-review.py in the file. Then in perforce click on Tools -> Import. After that if you right click on a changlist you should see "Submit CL for review" when you click on that it should post a review. One thing that i noticed is that if you have a submenu at the bottom of the P4 context menu, the new tool will be nested inside of that submenu.
On Thu, Sep 11, 2008 at 1:54 PM, 13Strider <[EMAIL PROTECTED]> wrote: > > no luck there, so how do i add the to perforce that i will get an > extra icon? > > On Sep 11, 11:22 am, "Joshua Slominski" <[EMAIL PROTECTED]> wrote: > > I have never seen that before. If you run it with debug info on do you > see > > anything interesting? > > > > On Thu, Sep 11, 2008 at 10:01 AM, 13Strider <[EMAIL PROTECTED] > >wrote: > > > > > > > > > no im getting this error > > > Unable to accesshttp://api/json/accounts/login/. The host path may be > > > invalid > > > > > On Sep 10, 5:54 pm, "Joshua Slominski" <[EMAIL PROTECTED]> wrote: > > > > Ok, you are using the first submission that i made that used a > wrapper > > > > executable to call post-review. If you look at revision 3, I have > > > modified > > > > post-review to do the same thing that the wrapper executable did. > Try > > > using > > > > that first. That way you don't need to compile anything. > > > > > > On Wed, Sep 10, 2008 at 4:26 PM, 13Strider < > [EMAIL PROTECTED]> > > > wrote: > > > > > > > yeah i can see that, im missing a file thought the direct.h thats > > > > > being used in p4Post-review.cpp > > > > > also where do i but the p4post-review.cpp, > > > > > sorry im a nob, thanks for the help/ > > > > > > > On Sep 10, 5:23 pm, "Joshua Slominski" <[EMAIL PROTECTED]> > wrote: > > > > > > I have submitted a change to post-review to handle this. It is > still > > > > > > pending review: > > > > > > > >http://reviews.review-board.org/r/467/ > > > > > > > > On Wed, Sep 10, 2008 at 4:01 PM, 13Strider < > > > [EMAIL PROTECTED]> > > > > > wrote: > > > > > > > > > Where can i find a clear description on how to make post review > > > work > > > > > > > with perforce? > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
