Russell Bryant wrote:
> On Wed, Nov 5, 2008 at 6:54 AM, Dave Hocker <[EMAIL PROTECTED] 
> <mailto:[EMAIL PROTECTED]>> wrote:
>     You can use the Perforce "p4 files" command to determine if Perforce
>     thinks the file is text or binary. The last token of the output will
>     be something like (text) or (binary+l). Note that for a binary file
>     the character after the + is the letter L in lower case. We've had
>     this issue and I plan to modify our post-review script to make this
>     check.
> You could do something with subversion, as well, by checking the 
> "svn:mime-type" property on files to see if they are text/plain or not.

Subversion won't try and diff binary files so there should be no need to 
put this logic in post-review. Where "should" maybe famous last words, 
I'm not using subversion with reviewboard so I've not actually sat down 
and tested this.


You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at

Reply via email to