We usually recommend using the full URL in the repository except for the bug
number. The bug number alone then goes in the bug list for the review
request. Usually there's no more than one bug tracker ever needed for a
repository, so this works well.

Christian

-- 
Christian Hammond - [EMAIL PROTECTED]
VMware, Inc.


On Mon, Dec 8, 2008 at 8:54 AM, Arthur Kalmenson <[EMAIL PROTECTED]>wrote:

>
> OK, so it seems that having a full link to the ticket is bad. I added
> the following URL for the bug tracker in the admin side:
>
> http://mshlindev/web-trac/%s
>
> Where web-trac is the root to all our Trac projects. To link to a
> specific ticket I just have to put
> <project-name>/ticket/<ticket-number> as the bug URL.
>
> --
> Arthur Kalmenson
>
>
>
> On Mon, Dec 8, 2008 at 11:21 AM, Arthur Kalmenson <[EMAIL PROTECTED]>
> wrote:
> > Hello everyone,
> >
> > I tried to publish a review that had the full link to the Trac ticket
> > that the patch was for. Now I get the error below. Is there any way to
> > fix the review request? Is there a way to just delete it and start
> > again? Thank you.
> >
> > P.S. I think it might have something to do with the internal server
> > naming (not using fully qualified domain name).
> >
> > Environment:
> >
> > Request Method: GET
> > Request URL: http://mshlindev/reviews/r/15/
> > Django Version: 1.0.2 final
> > Python Version: 2.5.2
> > Installed Applications:
> > ['django.contrib.admin',
> >  'django.contrib.auth',
> >  'django.contrib.contenttypes',
> >  'django.contrib.markup',
> >  'django.contrib.sites',
> >  'django.contrib.sessions',
> >  'djblets.datagrid',
> >  'djblets.feedview',
> >  'djblets.siteconfig',
> >  'djblets.util',
> >  'djblets.webapi',
> >  'reviewboard.accounts',
> >  'reviewboard.admin',
> >  'reviewboard.changedescs',
> >  'reviewboard.diffviewer',
> >  'reviewboard.iphone',
> >  'reviewboard.reports',
> >  'reviewboard.reviews',
> >  'reviewboard.scmtools',
> >  'reviewboard.webapi',
> >  'django_evolution']
> > Installed Middleware:
> > ('django.middleware.common.CommonMiddleware',
> >  'django.middleware.doc.XViewMiddleware',
> >  'django.middleware.locale.LocaleMiddleware',
> >  'django.contrib.sessions.middleware.SessionMiddleware',
> >  'django.contrib.auth.middleware.AuthenticationMiddleware',
> >  'djblets.siteconfig.middleware.SettingsMiddleware',
> >  'reviewboard.admin.middleware.LoadSettingsMiddleware',
> >  'djblets.log.middleware.LoggingMiddleware',
> >  'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
> >
> >
> > Template error:
> > In template
> /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081127-py2.5.egg/reviewboard/templates/reviews/review_request_box.html,
> > error at line 40
> >   Caught an exception while rendering: not all arguments converted
> > during string formatting
> >   30 :    <td class="value"><span id="target_groups">
> >
> >
> >   31 : {%  for group in review_request_details.target_groups.all %}
> >
> >
> >   32 : <a href="{% url group group %}">{{group}}</a>{%if not
> > forloop.last %}, {%endif %}
> >
> >
> >   33 : {%  endfor %}
> >
> >
> >   34 :   </span></td>
> >
> >
> >   35 :   </tr>
> >
> >
> >   36 :   <tr>
> >
> >
> >   37 :    <td class="label"><label for="bugs_closed">{% trans "Bugs"
> > %}:</label></td>
> >
> >
> >   38 :    <td class="value"><span id="bugs_closed">
> >
> >
> >   39 : {%  for bug in review_request_details.get_bug_list %}
> >
> >
> >   40 : {%   if review_request.repository.bug_tracker %}<a href=
> > {{bug|bug_url:review_request}} >{{bug}}</a>{% else %}{{bug}}{% endif
> > %}{% if not forloop.last %}, {% endif %}
> >
> >
> >   41 : {%  endfor %}
> >
> >
> >   42 :   </span></td>
> >
> >
> >   43 :    <td class="indented label"><label for="target_people">{%
> > trans "People" %}:</label></td>
> >
> >
> >   44 :    <td class="value"><span id="target_people">
> >
> >
> >   45 : {%  for person in review_request_details.target_people.all %}
> >
> >
> >   46 : <a href="{% url user person %}"{% if not person.is_active %}
> > class="inactive"{% endif %}>{{person}}</a>{% if not forloop.last %},
> > {% endif %}
> >
> >
> >   47 : {%  endfor %}
> >
> >
> >   48 :   </span></td>
> >
> >
> >   49 :   </tr>
> >
> >
> >   50 :   <tr>
> >
> >
> > Traceback:
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/handlers/base.py"
> > in get_response
> >  86.                 response = callback(request, *callback_args,
> > **callback_kwargs)
> > File
> "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081127-py2.5.egg/reviewboard/accounts/decorators.py"
> > in _check
> >  27.             return view_func(*args, **kwargs)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/views/decorators/cache.py"
> > in _cache_controlled
> >  30.             response = viewfunc(request, *args, **kw)
> > File
> "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081127-py2.5.egg/reviewboard/reviews/views.py"
> > in review_detail
> >  184.         'PRE_CREATION': PRE_CREATION,
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/shortcuts/__init__.py"
> > in render_to_response
> >  18.     return HttpResponse(loader.render_to_string(*args,
> > **kwargs), **httpresponse_kwargs)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/loader.py"
> > in render_to_string
> >  107.     return t.render(context_instance)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/__init__.py"
> > in render
> >  176.         return self.nodelist.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/__init__.py"
> > in render
> >  768.                 bits.append(self.render_node(node, context))
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/debug.py"
> > in render_node
> >  71.             result = node.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/loader_tags.py"
> > in render
> >  97.         return compiled_parent.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/__init__.py"
> > in render
> >  176.         return self.nodelist.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/__init__.py"
> > in render
> >  768.                 bits.append(self.render_node(node, context))
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/debug.py"
> > in render_node
> >  71.             result = node.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/loader_tags.py"
> > in render
> >  24.         result = self.nodelist.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/__init__.py"
> > in render
> >  768.                 bits.append(self.render_node(node, context))
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/debug.py"
> > in render_node
> >  71.             result = node.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Djblets-0.4.dev_20081127-py2.5.egg/djblets/util/decorators.py"
> > in render
> >  150.             return self.tag_func(context, self.nodelist, *args)
> > File
> "/usr/lib/python2.5/site-packages/Djblets-0.4.dev_20081127-py2.5.egg/djblets/util/templatetags/djblets_deco.py"
> > in box
> >  44.         'content': nodelist.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/__init__.py"
> > in render
> >  768.                 bits.append(self.render_node(node, context))
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/debug.py"
> > in render_node
> >  71.             result = node.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/loader_tags.py"
> > in render
> >  111.             return self.template.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/__init__.py"
> > in render
> >  176.         return self.nodelist.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/__init__.py"
> > in render
> >  768.                 bits.append(self.render_node(node, context))
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/debug.py"
> > in render_node
> >  71.             result = node.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/defaulttags.py"
> > in render
> >  148.                 nodelist.append(node.render(context))
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/defaulttags.py"
> > in render
> >  245.                     return self.nodelist_true.render(context)
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/__init__.py"
> > in render
> >  768.                 bits.append(self.render_node(node, context))
> > File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/debug.py"
> > in render_node
> >  81.             raise wrapped
> >
> > Exception Type: TemplateSyntaxError at /reviews/r/15/
> > Exception Value: Caught an exception while rendering: not all
> > arguments converted during string formatting
> >
> > Original Traceback (most recent call last):
> >  File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/debug.py",
> > line 71, in render_node
> >    result = node.render(context)
> >  File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/debug.py",
> > line 87, in render
> >    output = force_unicode(self.filter_expression.resolve(context))
> >  File
> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/template/__init__.py",
> > line 559, in resolve
> >    new_obj = func(obj, *arg_vals)
> >  File
> "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081127-py2.5.egg/reviewboard/reviews/templatetags/reviewtags.py",
> > line 354, in bug_url
> >    return review_request.repository.bug_tracker % bug_id
> > TypeError: not all arguments converted during string formatting
> >
> > --
> > Arthur Kalmenson
> >
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to