This is the unified diff for p4 

Can you give us the format of the expected diff?




From: []
On Behalf Of Christian Hammond
Sent: Friday, January 16, 2009 3:28 PM
Cc: Matthew Chang
Subject: Re: Cannot create review using Perforce


The revision is the SVN revision or nightly build.

Okay, so p4 diff is the problem. p4 diff doesn't provide the information
needed for doing any kind of code reviews. We expect certain information
in the diff, which isn't available. With Perforce, you'll have to use
post-review to post your changes. It's actually quicker and easier to do
so, anyway.


Christian Hammond -
VMware, Inc.

On Fri, Jan 16, 2009 at 3:11 PM, Cong Do <> wrote:

What revision of Review Board is this?  -> 0.9

Also, how are you generating the diff? -> p4 diff -du ...

Does post-review work?  -> didn't try

Christian Hammond -
VMware, Inc.

On Fri, Jan 16, 2009 at 2:32 PM, Cong Do <> wrote:


We tried to generate a code review using Perforce.
After entering pending change list and a unified diff file,
and pushing the 'Create Review Request' button, the diff file just

Has anyone run into this?

Unified diff file content:

==== //depot/test/MVP1.0.0/Makefile#1 -
/home/cdo/client_9/test/MVP1.0.0/Makefile ====
@@ -1,6 +1,6 @@
 include host/common.mak





You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to