This is the unified diff for p4 

Can you give us the format of the expected diff?

Cong.

 

________________________________

From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com]
On Behalf Of Christian Hammond
Sent: Friday, January 16, 2009 3:28 PM
To: reviewboard@googlegroups.com
Cc: Matthew Chang
Subject: Re: Cannot create review using Perforce

 

The revision is the SVN revision or nightly build.

Okay, so p4 diff is the problem. p4 diff doesn't provide the information
needed for doing any kind of code reviews. We expect certain information
in the diff, which isn't available. With Perforce, you'll have to use
post-review to post your changes. It's actually quicker and easier to do
so, anyway.

Christian

-- 
Christian Hammond - chip...@chipx86.com
VMware, Inc.



On Fri, Jan 16, 2009 at 3:11 PM, Cong Do <c...@rgbnetworks.com> wrote:

What revision of Review Board is this?  -> 0.9

Also, how are you generating the diff? -> p4 diff -du ...

Does post-review work?  -> didn't try





-- 
Christian Hammond - chip...@chipx86.com
VMware, Inc.

On Fri, Jan 16, 2009 at 2:32 PM, Cong Do <c...@rgbnetworks.com> wrote:


Hi,

We tried to generate a code review using Perforce.
After entering pending change list and a unified diff file,
and pushing the 'Create Review Request' button, the diff file just
disappeared.

Has anyone run into this?

Unified diff file content:

==== //depot/test/MVP1.0.0/Makefile#1 -
/home/cdo/client_9/test/MVP1.0.0/Makefile ====
@@ -1,6 +1,6 @@
 include host/common.mak

-HOST_DIR=host
+HOST_DIR=host2
 BIN_DIR=tools/bin/
 DO_DEP=$(BIN_DIR)do_dep.pl



 

 

 





--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to