It wouldn't have with last night's build. I didn't update the dependency for the new nightly.
Do an upgrade of Djblets as well and it should work. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Feb 3, 2009 at 2:43 PM, Matthew Von Bargen <mattv...@gmail.com>wrote: > > I don't know... > > If running "sudo easy_install --upgrade ReviewBoard" upgrades Djblets > then I upgraded it. If not, then I did not. > > On Tue, Feb 3, 2009 at 2:38 PM, Christian Hammond <chip...@chipx86.com> > wrote: > > Er, yeah, key.. I'm a bit out of it today. > > > > Did you upgrade Djblets as well? > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > VMware, Inc. > > > > > > On Tue, Feb 3, 2009 at 2:35 PM, Matthew Von Bargen <mattv...@gmail.com> > > wrote: > >> > >> Okay. Thanks. > >> > >> Did you mean: > >> > >> key += "-%s" % settings.AJAX_SERIAL > >> > >> instead of : > >> > >> str += "-%s" % settings.AJAX_SERIAL > >> > >> ? > >> > >> If I do what you say, but assign to +key+ instead of +str+, then > >> things mostly work. But I am still seeing one "Diff currently > >> unavailable." error: > >> > >> Diff currently unavailable. > >> Error: 'Settings' object has no attribute 'AJAX_SERIAL' > >> Details > >> Traceback (most recent call last): > >> File > >> > "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", > >> line 193, in view_diff_fragment > >> context, template_name)) > >> File > >> > "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", > >> line 53, in build_diff_fragment > >> key += "-%s" % settings.AJAX_SERIAL > >> File > >> > "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/conf/__init__.py", > >> line 32, in __getattr__ > >> return getattr(self._target, name) > >> AttributeError: 'Settings' object has no attribute 'AJAX_SERIAL' > >> > >> > >> > >> On Tue, Feb 3, 2009 at 2:05 PM, Christian Hammond <chip...@chipx86.com> > >> wrote: > >> > Odd that I didn't hit that during testing... > >> > > >> > I've committed a fix to SVN, but you can edit > >> > > >> > > /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py > >> > line 53 and change the line to: > >> > > >> > str += "-%s" % settings.AJAX_SERIAL > >> > > >> > I'm putting out the 1.0 alpha 2 release tonight, and this will be > fixed > >> > along with it. > >> > > >> > Christian > >> > > >> > -- > >> > Christian Hammond - chip...@chipx86.com > >> > VMware, Inc. > >> > > >> > > >> > On Tue, Feb 3, 2009 at 10:04 AM, mattvonb <mattv...@gmail.com> wrote: > >> >> > >> >> I recently upgraded my Review Board installation by running: > >> >> > >> >> sudo easy_install --upgrade ReviewBoard > >> >> > >> >> and > >> >> > >> >> sudo rb-site upgrade /path/to/my/install > >> >> > >> >> and now whenever I'm looking at a review and I click "View Diff" I > get > >> >> several of the following errors where the diffs would be: > >> >> > >> >> Diff currently unavailable. > >> >> Error: cannot concatenate 'str' and 'int' objects > >> >> > >> >> Clicking the Details link shows me: > >> >> > >> >> Traceback (most recent call last): > >> >> File "/usr/lib/python2.5/site-packages/ > >> >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ > >> >> views.py", line 193, in view_diff_fragment > >> >> context, template_name)) > >> >> File "/usr/lib/python2.5/site-packages/ > >> >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ > >> >> views.py", line 53, in build_diff_fragment > >> >> key += '-' + settings.AJAX_SERIAL > >> >> TypeError: cannot concatenate 'str' and 'int' objects > >> >> > >> >> > >> >> What did I do wrong, and how can I fix it. Thanks. > >> >> > >> >> > >> >> > >> > > >> > > >> > > > >> > > >> > >> > > > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
