Would you mind posting these up at http://reviews.review-board.org/ ?

Christian

-- 
Christian Hammond - chip...@chipx86.com
VMware, Inc.


On Wed, Feb 4, 2009 at 10:37 PM, ytht....@gmail.com <ytht....@gmail.com>wrote:

>
> Hi,
> There are two CVSClient Class in post-review. If you keep two, the
> first
> won't work, so the CVSClient is not ok now.
> The attachment patch will fix this.
>
> --- post-review.old     2009-02-05 14:29:23.000000000 +0800
> +++ post-review 2009-02-05 14:30:26.000000000 +0800
> @@ -1017,73 +1017,6 @@
>         ostr = ''.join(o)
>         return (ostr, None) # diff, parent_diff (not supported)
>
> -
> -class CVSClient(SCMClient):
> -    """
> -    A wrapper around the cvs tool that fetches repository
> -    information and generates compatible diffs.
> -    """
> -    def get_repository_info(self):
> -        if not check_install("cvs"):
> -            return None
> -
> -        cvsroot_path = os.path.join("CVS", "Root")
> -
> -        if not os.path.exists(cvsroot_path):
> -            return None
> -
> -        fp = open(cvsroot_path, "r")
> -        repository_path = fp.read().strip()
> -        fp.close()
> -
> -        i = repository_path.find("@")
> -        if i != -1:
> -            repository_path = repository_path[i + 1:]
> -
> -        i = repository_path.find(":")
> -        if i != -1:
> -            host = repository_path[:i]
> -            try:
> -                canon = socket.getfqdn()
> -                repository_path = repository_path.replace('%s:' %
> host,
> -                                                          '%s:' %
> canon)
> -            except socket.error, msg:
> -                debug("failed to get fqdn for %s, msg=%s" % (host,
> msg))
> -
> -        return RepositoryInfo(path=repository_path)
> -
> -    def diff(self, files):
> -        """
> -        Performs a diff across all modified files in a CVS
> repository.
> -
> -        CVS repositories do not support branches of branches in a way
> that
> -        makes parent diffs possible, so we never return a parent diff
> -        (the second value in the tuple).
> -        """
> -        return (self.do_diff(files), None)
> -
> -    def diff_between_revisions(self, revision_range):
> -        """
> -        Performs a diff between 2 revisions of a CVS repository.
> -        """
> -        revs = []
> -
> -        for rev in revision_range.split(":"):
> -            revs += ["-r", rev]
> -
> -        return self.do_diff(revs)
> -
> -    def do_diff(self, params):
> -        """
> -        Performs the actual diff operation through cvs diff, handling
> -        fake errors generated by CVS.
> -        """
> -        # Diff returns "1" if differences were found.
> -        return execute(["cvs", "diff", "-uN"] + params,
> -                        extra_ignore_errors=(1,))
> -
> -
> -
>  class SVNClient(SCMClient):
>     """
>     A wrapper around the svn Subversion tool that fetches repository
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to