Try using post-review. IIRC, TortoiseSVN generates slightly non-standard
diffs that cause problems. It would be nice to work around this, though.

post-review also just makes filing review request a lot easier.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Feb 13, 2009 at 3:53 PM, Darren <spaces...@gmail.com> wrote:

>
> Repository is SVN, and the diff was created by TortiseSVN on windows.
>
> Diff was uploaded by hand through the web UI.
>
> Darren.
>
> On Feb 13, 2:08 pm, Christian Hammond <chip...@chipx86.com> wrote:
> > Sounds like the diff header didn't have the information we expected
> > signifying that this was a new file. What repository type is this, and
> what
> > did you use to create/upload the diff?
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.review-board.org
> > VMware, Inc. -http://www.vmware.com
> >
> > On Fri, Feb 13, 2009 at 11:53 AM, Darren <spaces...@gmail.com> wrote:
> >
> > > Hi all,
> >
> > > Just tried uploading a diff based on changes to our instance of
> > > reviewboard.
> >
> > > The diff contains a number of changes to existing code, plus the
> > > addition of two new files.
> >
> > > When I click "View Diff" the changes to existing code display
> > > correctly.  However, in the "Files Changed" summary the files that
> > > were added have the following message: "Diff currently unavailable."
> >
> > > If I scroll down to the file display, I can see the following error:
> >
> > > /OpenRoad.ThoughtFarmer.Core/Caching/ConfigSettingsCacheService.cs
> > > Revision 12789  New Change
> > > Diff currently unavailable.
> > > Error: The file '/OpenRoad.ThoughtFarmer.Core/Caching/
> > > ConfigSettingsCacheService.cs' (r12789) could not be found in the
> > > repository: File not found: revision 12789, path '/projects/
> > > ThoughtFarmer/trunk/OpenRoad.ThoughtFarmer.Core/Caching/
> > > ConfigSettingsCacheService.cs'
> > > Details
> >
> > > This seems like an odd error -- of course the file isn't in the
> > > repository, it's a new file and hasn't been checked in yet.  I would
> > > expect ReviewBoard to allow me to review the code, but no diff would
> > > be necessary.
> >
> > > Is this a bug, or am I missing something?
> >
> > > Darren.
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to