Hi Christian,

thank you so much!
It works again :)

Martin

On Mar 30, 2:16 am, Christian Hammond <chip...@chipx86.com> wrote:
> We've released beta 2, which should fix this. Go ahead and upgrade and make
> sure it works fine for you.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
>
> On Sun, Mar 29, 2009 at 9:58 PM, Christian Hammond <chip...@chipx86.com>wrote:
>
> > Looks like there were some breakages in the upgrade to the new jQuery.
> > Prepare for a new release late tonight...
>
> > Christian
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.review-board.org
> > VMware, Inc. -http://www.vmware.com
>
> > On Sun, Mar 29, 2009 at 9:15 PM, Martin <mkoeb...@gmail.com> wrote:
>
> >> phew, good. thank you!
> >> I appreciate your efforts!
>
> >> On Mar 30, 12:13 am, Christian Hammond <chip...@chipx86.com> wrote:
> >> > Huh, I'm actually seeing this too on one of my installs. I'm looking
> >> into it
> >> > and will get back to you.
>
> >> > Christian
>
> >> > --
> >> > Christian Hammond - chip...@chipx86.com
> >> > Review Board -http://www.review-board.org
> >> > VMware, Inc. -http://www.vmware.com
>
> >> > On Sun, Mar 29, 2009 at 9:11 PM, Martin <mkoeb...@gmail.com> wrote:
>
> >> > > the error points into the js code:
> >> > > I added "[line 361:] " which firefox tells me where the error occurs.
>
> >> > >  /*
> >> > >     * Shows the comment dialog.
> >> > >     */
> >> > >    showCommentDlg: function() {
> >> > >        var self = this;
>
> >> > >        if (gCommentDlg == null) {
> >> > >            gCommentDlg = $("#comment-detail")
> >> > >                .commentDlg()
> >> > >                .css("z-index", 999)
> >> > >                .appendTo("body");
> >> > >        }
>
> >> > >        gCommentDlg
> >> > > [line 361:]            .one("close", function() {
> >> > >                 gCommentDlg
> >> > >                    .setCommentBlock(self)
> >> > >                    .css({
> >> > >                        left: $(document).scrollLeft() +
> >> > >                              ($(window).width() - gCommentDlg.width
> >> > > ()) / 2,
> >> > >                        top:  self.endRow.offset().top +
> >> > >                              self.endRow.height()
> >> > >                    })
> >> > >                    .open(self.el);
> >> > >            })
> >> > >             .close();
> >> > >    },
>
> >> > > On Mar 30, 12:08 am, Martin <mkoeb...@gmail.com> wrote:
> >> > > > I also restarted memcached.
>
> >> > > > On Mar 30, 12:06 am, Martin <mkoeb...@gmail.com> wrote:
>
> >> > > > > I use django 1.0.2 final if that matters.
>
> >> > > > > On Mar 30, 12:05 am, Martin <mkoeb...@gmail.com> wrote:
>
> >> > > > > > after the easy_install I did
>
> >> > > > > > [r...@vmcodereview ~]# rb-site upgrade /var/www/reviewboard
> >> > > > > > Rebuilding directory structure
> >> > > > > > Updating database
> >> > > > > > Upgrading Review Board from 1.0alpha4 to 1.0beta1
> >> > > > > > Installing json fixture 'initial_data' from
> >> '/usr/lib/python2.4/site-
> >> > > > > > packages/ReviewBoard-1.0beta1-py2.4.egg/reviewboard/scmtools/
> >> > > > > > fixtures'.
> >> > > > > > Installed 6 object(s) from 1 fixture(s)
> >> > > > > > No evolution required.
>
> >> > > > > > On Mar 30, 12:04 am, Martin <mkoeb...@gmail.com> wrote:
>
> >> > > > > > > yes, I did.
>
> >> > > > > > > On Mar 29, 11:59 pm, Christian Hammond <chip...@chipx86.com>
> >> > > wrote:
>
> >> > > > > > > > Did you run `rb-site upgrade` on the new site and restart
> >> the
> >> > > Apache server?
>
> >> > > > > > > > Christian
>
> >> > > > > > > > --
> >> > > > > > > > Christian Hammond - chip...@chipx86.com
> >> > > > > > > > Review Board -http://www.review-board.org
> >> > > > > > > > VMware, Inc. -http://www.vmware.com
>
> >> > > > > > > > On Sun, Mar 29, 2009 at 8:55 PM, Martin <mkoeb...@gmail.com
>
> >> > > wrote:
>
> >> > > > > > > > > Hi,
>
> >> > > > > > > > > when I click on a line of code in the diff viewer, I get
> >> this
> >> > > error
> >> > > > > > > > > message in firefox 3 after upgrading to the first beta
> >> release:
>
> >> > > > > > > > > Error: gCommentDlg.one("close", function ()
> >> > > > > > > > > {gCommentDlg.setCommentBlock(self).css({left:
> >> > > $(document).scrollLeft()
> >> > > > > > > > > + ($(window).width() - gCommentDlg.width()) / 2, top:
> >> > > > > > > > > self.endRow.offset().top + self.endRow.height()}).open
> >> > > > > > > > > (self.el);}).close is not a function
> >> > > > > > > > > Source File:
>
> >> > >http://codereview/reviewboard/media/rb/js/diffviewer.js?1238384481
> >> > > > > > > > > Line: 361
>
> >> > > > > > > > > I did clear the browser cache.
>
> >> > > > > > > > > Please help.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to