It's a Subversion 1.5 repo. I did upgrade to beta-2 but I still see the same problem. Weird though that it is seen only with this diff(or rather revision). When I add other revisions(using --revision-range option) to the same review(-r option) I am able to see the diff.
On Apr 1, 2:10 am, Christian Hammond <chip...@chipx86.com> wrote: > What type of repository is this file against? > > Can you upgrade to beta 2 and try again? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.review-board.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Mar 31, 2009 at 11:09 AM, Ashwin <ashwinu...@gmail.com> wrote: > > > Hi, > > > When I do View Diff I get this error : > > > Traceback (most recent call last): > > File "c:\apps\actpython\lib\site-packages\ReviewBoard-1.0alpha4- > > py2.5.egg\reviewboard\diffviewer\views.py", line 145, in view_diff > > interdiffset, highlighting, True)[0] > > File "c:\apps\actpython\lib\site-packages\ReviewBoard-1.0alpha4- > > py2.5.egg\reviewboard\diffviewer\diffutils.py", line 619, in > > get_diff_files > > large_data=True) > > File "c:\apps\actpython\lib\site-packages\Djblets-0.5alpha3- > > py2.5.egg > > \djblets\util\misc.py", line 143, in cache_memoize > > data = lookup_callable() > > File "c:\apps\actpython\lib\site-packages\ReviewBoard-1.0alpha4- > > py2.5.egg\reviewboard\diffviewer\diffutils.py", line 618, in <lambda> > > enable_syntax_highlighting), > > File "c:\apps\actpython\lib\site-packages\ReviewBoard-1.0alpha4- > > py2.5.egg\reviewboard\diffviewer\diffutils.py", line 342, in > > get_chunks > > new = get_patched_file(old, filediff) > > File "c:\apps\actpython\lib\site-packages\ReviewBoard-1.0alpha4- > > py2.5.egg\reviewboard\diffviewer\diffutils.py", line 258, in > > get_patched_file > > return patch(filediff.diff, buffer, filediff.dest_file) > > File "c:\apps\actpython\lib\site-packages\ReviewBoard-1.0alpha4- > > py2.5.egg\reviewboard\diffviewer\diffutils.py", line 98, in patch > > f.write(convert_line_endings(file)) > > File "c:\apps\actpython\lib\site-packages\ReviewBoard-1.0alpha4- > > py2.5.egg\reviewboard\diffviewer\diffutils.py", line 82, in > > convert_line_endings > > if data[-1] == "\r": > > TypeError: 'NoneType' object is unsubscriptable > > > This does not happen for every diff though. I used post-review to add > > the diff into a review. I am able to download the diff file but I am > > not able to view it using the "ViewDiff" option. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
