Well, everyone who uses p4 will probably rather use post-review. ;) The tool in the rbtools/contrib should probably be renamed something with "p4win" in it, as it is an extension for p4win, and a lot of people use p4v now since p4win has been deprecated for a few years. I keep starting to make a similar extension ("custom tool") for p4v but their "terminal" isn't a real terminal and can't handle the method post-review uses to collect your password if you need to authenticate. That's certainly something that can be handled pretty easily... post-review, or a wrapper (or preferably a rbapi library) probably needs a way of finding out if you are authenticated or not that doesn't go directly to asking you for your password.
-- Paul ________________________________________ From: email@example.com [reviewbo...@googlegroups.com] On Behalf Of Joshua Slominski [hoohaa8...@gmail.com] Sent: Wednesday, June 10, 2009 9:44 AM To: firstname.lastname@example.org Subject: Re: need help to integrate post-review with Perforce There is a P4 tool located in rbtools/ contrib. If you set that up there is no need to run post-review from the command line. On Tue, Jun 9, 2009 at 4:49 PM, Christian Hammond <chip...@chipx86.com<mailto:chip...@chipx86.com>> wrote: There's a lot of documentation on this at http://www.review-board.org/docs/manual/dev/users/tools/post-review/ Christian -- Christian Hammond - chip...@chipx86.com<mailto:chip...@chipx86.com> Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Jun 9, 2009 at 1:34 AM, Amit <agrawalamit2...@gmail.com<mailto:agrawalamit2...@gmail.com>> wrote: Hi, I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed for integrating post-review into Perforce. Any help will be highly appreciated. -Amit --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to email@example.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---