Definitely.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Jun 19, 2009 at 5:53 AM, Raghu <raghu...@gmail.com> wrote:

>
> Just adding my two cents.
>
> Yes, this will be a very useful feature. It's also worth mentioning
> that many teams within an organization may be sharing a single SCM
> repository but
> may have different policies. So it might be useful to tie policies
> with SCM paths rather than at repository level.
>
> Thanks,
> Raghu
>
> On Jun 19, 5:10 am, Eduardo Felipe <eduardofelip...@gmail.com> wrote:
> > Well, that actually is part of my Google Summer of Code project for
> > ReviewBoard, hehehe.
> >
> > []s
> >
> > Edu Felipe
> >
> > On Thu, Jun 18, 2009 at 5:18 PM, Christian Hammond<chip...@chipx86.com>
> wrote:
> > > We're waiting until 1.5 to change any of this. We want to introduce a
> > > concept of policy that allows for specifying rules like this, but until
> > > then, we really don't want to change this logic, as different companies
> > > handle this differently.
> >
> > > For example, some people want to see this only since the last diff
> update.
> > > One might argue that you should be able to specify when uploading the
> diff
> > > whether this is a new diff worth a new review (thus resetting ship-it
> > > counts) or not, but then we have to add support in post-review and the
> API,
> > > and figure out how all that works.
> >
> > > Some people want the Ship It to only appear if there's some number of
> > > reviewers, or some number of very specific reviewers (say, senior
> > > engineers), or some percentage, or all of the people specifically on
> the
> > > reviewer list, etc.
> >
> > > Until we have a concept of policy, not everyone will be happy, so right
> now
> > > we keep it as simple as possible and leave it up to people to interpret
> it
> > > how they choose.
> >
> > > Christian
> >
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.review-board.org
> > > VMware, Inc. -http://www.vmware.com
> >
> > > On Thu, Jun 18, 2009 at 5:59 AM, Sebastien Douche <sdou...@gmail.com>
> wrote:
> >
> > >> Hi,
> > >> here we use a different shipit counting : we count only the number of
> > >> shipit where the timestamp is more recent than last diff. The goal is
> > >> to see shipit only for the last diff, shipit on precious diff is not
> > >> relevant.
> >
> > >> Christian, what do you think about that?
> >
> > >> --
> > >> Sebastien Douche <sdou...@gmail.com>
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to