Kind of a strange issue here.

I created a diff file via Trac (OSS project mgmt software), but Review Board 
won't accept it.   Here's the error I receive:
"No valid separator after the filename was found in the diff header"

The exact same diff if procured via the Subversion client works fine.

Upon examining both diffs (attached) the only different I see is in the 
following two lines:

--- /root/branches/someBranch/the_file.cfm (revision 8375)
+++ /root/branches/someBranch/the_file.cfm (revision 8376)


The space between ".cfm (revision" is a space in the Trac diff (0x20) but in 
the Subversion diff it's a tab (0x09).  Is 
the Trac diff truly an invalid diff, or is Review Board just being picky?

Thanks,
Eric P.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Index: /root/branches/someBranch/the_file.cfm
===================================================================
--- /root/branches/someBranch/the_file.cfm	(revision 8375)
+++ /root/branches/someBranch/the_file.cfm	(revision 8376)
@@ -2,6 +2,7 @@
 <cfsilent>
 	<cfparam name="URL.abcID" type="numeric" default="-1">
 	<cfparam name="URL.defID" default="-1">
+	<cfparam name="URL.ooID"    type="numeric" default="-1">  <!--- oo = ID --->
 	<cfparam name="URL.ro"    type="boolean" default="0">	<!--- ro = ro --->
 	<cfinclude template="inc.cfm">
 
@@ -64,6 +65,7 @@
 				UserID="#query.UserID#"
 				ProfileID="#query.ProfileID#"
 				LocationID="#query.LocationID#"
+				ooID="#URL.ooID#"
 				Reload="#URL.ro#"
 			>
 		</div>
Index: /root/branches/someBranch/the_file.cfm
===================================================================
--- /root/branches/someBranch/the_file.cfm (revision 8375)
+++ /root/branches/someBranch/the_file.cfm (revision 8376)
@@ -2,6 +2,7 @@
 <cfsilent>
 	<cfparam name="URL.abcID" type="numeric" default="-1">
 	<cfparam name="URL.defID" default="-1">
+	<cfparam name="URL.ooID"    type="numeric" default="-1">  <!--- oo = ID --->
 	<cfparam name="URL.ro"    type="boolean" default="0">	<!--- ro = ro --->
 	<cfinclude template="inc.cfm">
 
@@ -64,6 +65,7 @@
 				UserID="#query.UserID#"
 				ProfileID="#query.ProfileID#"
 				LocationID="#query.LocationID#"
+				ooID="#URL.ooID#"
 				Reload="#URL.ro#"
 			>
 		</div>

Reply via email to