I use the diff upload form when I want to make a more complex diff. I added the current simple support for git just so something was available but it needs a lot more flexibility to really follow the distributed spirit.
I think it might be better to take whatever git diff will take, so I can specify something like HEAD^ or HEAD~3..HEAD~1, etc. This would be just one argument. The 'new' and 'origin' arguments would work as well. Dan On Jul 8, 8:37 am, Petter Måhlén <pettermah...@gmail.com> wrote: > Despite not being a Python programmer, I found out through looking at > the code that there does seem to be a requirement that you compare > against the master branch. I've been able to change that, so we should > be able to proceed. The solution we preferred involves two arguments > that we called 'new' and 'origin', which allows you to specify two Git > commit-ishes to create a review request for. It would be interesting > to hear if that seems like a sensible solution to those of you who > have used this tool for a while? > > On Jul 8, 11:57 am, Petter Måhlén <pettermah...@gmail.com> wrote: > > > Hi, > > > I'm trying to figure out how to set up Review Board for usage within > > our organisation. We're using Git for SCM, so the Git support in RB is > > one of the things that made me want to take a closer look. However, > > I'm having some problems in understanding how to get going. It seems > > from the documentation as if the solution would be to use the post- > > review tool to get review requests into RB. The documentation > > indicates that a command like > > > post-review --parent=somebranch > > > should generate a diff between 'master' and that branch. However, for > > various reasons, we're not using branches named 'master'. This means > > that the command fails with a message like: > > > Failed to execute command: ['git', 'diff', '--no-color', 'master'] > > fatal: ambiguous argument 'master': unknown revision or path not in > > the working tree. > > > Is there some other way of using post-review to indicate the two > > revisions I want to diff and post a review for? > > > Thanks, > > Petter > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to firstname.lastname@example.org To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---