Good to hear.

I have a patch that will be going in to 1.0.1 that will check for this
before trying to serve any URLs, and inform the user as to how to fix it, so
this won't be as big a problem for future users.

Thanks!

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Thu, Jul 16, 2009 at 6:16 AM, paul <paul.grib...@gmail.com> wrote:

>
> Thanks again Christian,
> That's done the trick. I tried each solution separately and either one
> works fine.
>
> On Jul 16, 10:15 am, Christian Hammond <chip...@chipx86.com> wrote:
> > Yep, common problem. patch.exe isn't in the path that Apache sees. I
> believe
> > some people have solved this by making sure it's part of the global
> system
> > path, or by setting the path using the SetEnv command in the Apache
> config
> > file. Do let me know if the former works, and I'll add it to the docs.
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.review-board.org
> > VMware, Inc. -http://www.vmware.com
> >
> > On Thu, Jul 16, 2009 at 1:36 AM, paul <paul.grib...@gmail.com> wrote:
> >
> > > Thanks Christian,
> >
> > > I've now set the URL to the repository base, and when I run 'post-
> > > review' I now get a more promising response:
> >
> > > Review request #12 posted.
> > >http://localhost:8888/r/12
> >
> > > However when I click 'View Diff' for the generated review request, I
> > > get the following in the content pane (below).
> > > Any ideas?
> >
> > > Paul
> >
> > > Traceback (most recent call last):
> > >  File "c:\program files\python_2.5.4\lib\site-packages
> > > \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\views.py", line
> > > 152, in view_diff
> > >    interdiffset, highlighting, True)
> > >  File "c:\program files\python_2.5.4\lib\site-packages
> > > \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py",
> > > line 623, in get_diff_files
> > >    large_data=True)
> > >  File "c:\program files\python_2.5.4\lib\site-packages\Djblets-0.5-
> > > py2.5.egg\djblets\util\misc.py", line 143, in cache_memoize
> > >    data = lookup_callable()
> > >  File "c:\program files\python_2.5.4\lib\site-packages
> > > \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py",
> > > line 622, in <lambda>
> > >    enable_syntax_highlighting),
> > >  File "c:\program files\python_2.5.4\lib\site-packages
> > > \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py",
> > > line 345, in get_chunks
> > >    new = get_patched_file(old, filediff)
> > >  File "c:\program files\python_2.5.4\lib\site-packages
> > > \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py",
> > > line 261, in get_patched_file
> > >    return patch(filediff.diff, buffer, filediff.dest_file)
> > >  File "c:\program files\python_2.5.4\lib\site-packages
> > > \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py",
> > > line 109, in patch
> > >    stderr=subprocess.STDOUT)
> > >  File "C:\Program Files\Python_2.5.4\lib\subprocess.py", line 594, in
> > > __init__
> > >    errread, errwrite)
> > >  File "C:\Program Files\Python_2.5.4\lib\subprocess.py", line 822, in
> > > _execute_child
> > >    startupinfo)
> > > WindowsError: [Error 2] The system cannot find the file specified
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to