I'm wondering if the web interface could also be used for git. Today I
tried to create a "New Review Request" using the web interface on
http://reviews.review-board.org and failed miserably. I'm new to git
and as I have never used git with RB I'm wondering if git diffs are
fully supported through the web interface.

My diff was always rejected with the following error message:
The file 'reviewboard/diffviewer/forms.py' (r36800c1) could not be
found in the repository

The diff was produced with "$ git diff"

diff --git a/reviewboard/diffviewer/forms.py b/reviewboard/diffviewer/
forms.py
index 36800c1..9d9a1c1 100644
--- a/reviewboard/diffviewer/forms.py
+++ b/reviewboard/diffviewer/forms.py
@@ -127,6 +127,8 @@ class UploadDiffForm(forms.Form):
         tool = self.repository.get_scmtool()

         for f in tool.get_parser(file.read()).parse():
+            if f.binary:
+                continue
             f2, revision = tool.parse_diff_revision(f.origFile,
f.origInfo)
             if f2.startswith("/"):
                 filename = f2

Thanks in advance,
Philipp



On Sep 16, 1:25 am, Matthew Woehlke <mw_tr...@users.sourceforge.net>
wrote:
> On 2009-09-15 18:07, Kunjal wrote:
>
> > We already have RB integrated with Perforce and it is working cool.
> > Now, we have some developers working in GIT and we want to review that
> > code as well.
> > What are the steps developer should perform to get the diff and post
> > the review?
>
> Save yourself a whole lot of trouble and use post-review :-).
>
> Or to answer your question more literally, here are the steps:
> $ post-review -d # <other options>
>
> ...and you can omit -d if you don't want the noise of seeing what it is
> doing. (You'll also need to install RBTools once per machine, or else
> just snag postreview.py and make sure everyone has a copy.)
>
> --
> Matthew
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to