Yeah, it's a pain. I really do want to improve our repository comparison
code. Right now we use a direct look-up for efficiency reasons, but if we
cached the results and allowed each repository backend to do its own
comparison, we could remove some of these complications.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Sep 21, 2009 at 12:41 PM, Lacoste, Dana (TSG Software San Diego) <
dana.laco...@hp.com> wrote:

>  Yeah, this one got me.
>
>
>
> Particularly because what I set for my "$P4PORT" was NOT what the server
> returned in `p4 info` (I used an IP address because I've had DNS issues in
> the past, but the server returned its hostname.)
>
>
>
> J
>
>
>
> Dana Lacoste
>
>
>
> *From:* reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com]
> *On Behalf Of *Christian Hammond
> *Sent:* Monday, September 21, 2009 12:31 PM
> *To:* reviewboard@googlegroups.com
> *Subject:* Re: post-review login issue
>
>
>
> Make sure that the repository Path field matches *exactly* what you see
> when running 'p4 info'. We do a literal string comparison.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.review-board.org
> VMware, Inc. - http://www.vmware.com
>
>  On Mon, Sep 21, 2009 at 10:55 AM, Hui Lin <hui....@bankofamerica.com>
> wrote:
>
>
> Thanks Christian. I resolved the issue by install the 1.0.3 version
> and re-create the site.
>
> Now post-review is able to logon the reviewer board server, but gets
> problem of understanding the "repository_path" of the SCM (Perforce):
>    >>> Attempting to create review request for 388600
>    >>> HTTP POSTing to http://b002481234dc0/api/json/reviewrequests/new/:
> {'repository_path': 'chigfxldwb32:1667', 'changenum': '388600'}
>    Error creating review request: The repository path specified is
> not in the list of known repositories (code 206)
>
> "chigfxldwb32:1667" is the Perforce port, which I have no trouble to
> connect to it through either the p4 command or the P4V GUI client.
>
> What else should be in the "repository path" for Perforce other than
> the "port" information? Is there a way to find out what Perforce
> command has been executed by the reviewer board server?
>
>
>
>
> On Sep 20, 10:41 pm, Christian Hammond <chip...@chipx86.com> wrote:
> > Depends. You may just have logging turned off. Go in the Administration
> UI
> > -> Settings -> Logging and make sure it's enabled and being store in a
> > directory writable by the web server.
> >
> > Christian
> >
> > --
>
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.review-board.org
> > VMware, Inc. -http://www.vmware.com
> >
>
> > On Sun, Sep 20, 2009 at 5:57 PM, Hui Lin <hui....@bankofamerica.com>
> wrote:
> >
> > > The apache server was installed to just host the review board server,
> > > so I doubt there is another vhost serviced by it. I noticed that the
> > > logs directory of review board is empty. Is that strange?
> >
> > > On Sep 20, 7:23 pm, Christian Hammond <chip...@chipx86.com> wrote:
> > > > Okay, so Review Board itself is correct. However, post-review is
> somehow
> > > not
> > > > accessing the same server. This may be a configuration error on the
> web
> > > > server. How many other virtual hosts is that server serving? It may
> be
> > > worth
> > > > checking the log files of the other vhosts to find out which site is
> > > > actually serving that. I suspect it's not the Review Board one.
> >
> > > > Christian
> >
> > > > --
> > > > Christian Hammond - chip...@chipx86.com
> > > > Review Board -http://www.review-board.org
> > > > VMware, Inc. -http://www.vmware.com
> >
> > > > On Sun, Sep 20, 2009 at 5:18 PM, Hui Lin <hui....@bankofamerica.com>
> > > wrote:
> >
> > > > > "http://b00237d4f5dc7/reviews/vtm/"; redirect me to the dashboard.
> > > > > Going to "
> http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/";
> > > > > in the browser returns an empty page.
> >
> > > > > On Sep 20, 6:17 pm, Christian Hammond <chip...@chipx86.com> wrote:
> > > > > > It sounds like the server isn't configured at that URL correctly,
> or
> > > > > > post-review is hitting the wrong IP address/server.
>
> > > > > Doeshttp://b00237d4f5dc7/reviews/vtm/redirectyouto the dashboard or
>
> > > login
> > > > > > page in your browser? What happens when going
> > > > > tohttp://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/inthe
> > > browser?
> >
> > > > > > Christian
> >
> > > > > > --
> > > > > > Christian Hammond - chip...@chipx86.com
> > > > > > Review Board -http://www.review-board.org
> > > > > > VMware, Inc. -http://www.vmware.com
> >
> > > > > > On Sat, Sep 19, 2009 at 9:57 PM, Hui Lin <
> hui....@bankofamerica.com>
> > > > > wrote:
> >
> > > > > > > I was trying to create a post review request with the command
> on
> > > > > > > Windows:
> > > > > > >    post-review 388600
> >
> > > > > > > 388600 is the changelist # of perforce.
> >
> > > > > > > The script was able generate the diff but failed on logon the
> > > review
> > > > > > > board server, its url is:
> > > > > > >    http://b00237d4f5dc7/reviews/vtm/
> >
> > > > > > > The error message showing was:
> > > > > > >    Unable to access
> > > > > > >http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/.
> > > > > > > The host path may be invalid
> > > > > > >    HTTP Error 404: Not Found
> >
> > > > > > > I tried to enter the username / password at the prompts, as
> well as
> > > > > > > putting them into parameters "--username" and "--password", but
> > > > > > > neither way worked. I have no trouble logon with the same
> account
> > > on
> > > > > > > the web page.
> >
> > > > > > > What could be wrong?
> >
> > > > > > > Thanks for the help in advance.
>
>
>
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to