The 500 error is odd. I'll look into it. Fortunately that's just an admin-side thing, and it may be specific to the 1.1 dev branch.
This is the bug I was thinking of: http://code.google.com/p/reviewboard/issues/detail?id=831 Note that this shouldn't impact reviewers. It's only in the case where you want to comment on your own diff before publishing. While we'll probably fix the 404, we may still not allow users to do this just yet, as it gets kinda hairy. If you were to create a "review" of your own diff, and then replace that diff before publishing, then what happens with the review? We can't migrate it. We'd have to delete it. That's not a big deal, except throughout this whole thing, this review is going to be public. We *could* do things to make sure users never see a review associated with a draft diff, but there's just a lot to consider and I'm not wild about doing it right now. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Wed, Sep 23, 2009 at 5:16 PM, Pv <p...@swooby.com> wrote: > > Yes, I meant to install and try out the dev version. > > The review was still a draft and had not been published. > I published the review and could make a comment fine. > > I did a quick discussion search for 404 (and related), but did not see > anything. > > Also interesting, when I had the review in draft and used the admin to > view the "review request draft to change" I got a 500 error. > Once published I can admin the non-draft review just fine. > > Pv > > On Sep 23, 5:05 pm, Christian Hammond <chip...@chipx86.com> wrote: > > Hi, > > > > Yep, this is the right mailing list. > > > > So first of all, did you mean to install the in-development version? > That's > > perfectly fine, but I want to make sure. > > > > Was the review request published? Or did you leave a comment on the diff > > before publishing the review request? That will cause this. There's a bug > or > > two open on this somewhere. > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.review-board.org > > VMware, Inc. -http://www.vmware.com > > > > > > > > On Wed, Sep 23, 2009 at 4:56 PM, Pv <p...@swooby.com> wrote: > > > > > I just got Review Board up and running today using Apache+mod_python > > > +memcache on Windows (py25). > > > > > First question: Is this the right group to post a question to? :) > > > > > Things seem to work fairly smoothly, but when I try to save a comment > > > to a line of code in a diff I get a 404 at the top of the screen. > > > Looking at my apache log I see the following: > > > > > No FileDiff matches the given query. > > > Traceback (most recent call last): > > > File "c:\python25\lib\site-packages\django-1.1-py2.5.egg\django\core > > > \handlers\base.py", line 92, in get_response > > > response = callback(request, *callback_args, **callback_kwargs) > > > File "c:\python25\lib\site-packages\django-1.1-py2.5.egg\django\views > > > \decorators\cache.py", line 44, in _wrapped_view_func > > > response = view_func(request, *args, **kwargs) > > > File "c:\python25\lib\site-packages\ReviewBoard-1.1alpha1-py2.5.egg > > > \reviewboard\webapi\decorators.py", line 20, in _check > > > return view_func(request, *args, **kwargs) > > > File "c:\python25\lib\site-packages\ReviewBoard-1.1alpha1-py2.5.egg > > > \reviewboard\webapi\json.py", line 1345, in diff_line_comments > > > diffset__revision=diff_revision) > > > File "c:\python25\lib\site-packages\django-1.1-py2.5.egg\django > > > \shortcuts\__init__.py", line 87, in get_object_or_404 > > > raise Http404('No %s matches the given query.' % > > > queryset.model._meta.object_name) > > > Http404: No FileDiff matches the given query. > > > > > The diff was uploaded via the post-review tool. > > > > > Pv > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
