Christian,

Thanks for information about the --full-index option.

The good news is that the previous error no longer occurs. The bad
news is that there is now an "int argument required" error in its
place.

I would use post-review, unfortunately the machine I am working on is
behind a firewall and only has outside access via a web proxy, and the
reviews site will not accept "http://github.com/reviewboard/
reviewboard.git" as the repository URL. Altering the repository URL to
git://github.com/reviewboard/reviewboard.git" did not work as post-
review tries to communicate with the repository.

Setting up post-review on a machine with real internet access would
work, but surely there's a better way to do this?


Regards,
Solomon

--
Solomon Matthews
Systems Engineer
Australian Centre for Field Robotics
The University of Sydney

On Oct 2, 2:47 pm, Christian Hammond <chip...@chipx86.com> wrote:
> Hi,
>
> Looks like we're not importing the "logging" module in scmtools/git.py. I'll
> fix this and update the site after tonight's midnight (PST) build.
>
> The reason you're getting the error, though, is that our git support
> requires a full SHA1 instead of the default shortened SHA1 in order to look
> up files from GitHub. I recommend either using post-review (which makes it
> far easier to post/update review requests), or passing the --full-index
> option to `git diff`.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
>
> On Thu, Oct 1, 2009 at 7:24 PM, smat <g...@cictec.com> wrote:
>
> > Dear all,
>
> > I have recently set up Review Board for my organization, and in the
> > process found what looks like a bug in group enumeration in the AD
> > authentication backend. I would like to submit a fix for the project's
> > configuration. When I try to create a new review request, an error
> > message "global name 'logging' is not defined" appears next to "diff"
> > on the new review request page when I click "create review request".
> > This is the patch that I attached:
>
> > diff --git a/reviewboard/accounts/backends.py b/reviewboard/accounts/
> > backends.py
> > index 59da9cc..c3a1ea4 100644
> > --- a/reviewboard/accounts/backends.py
> > +++ b/reviewboard/accounts/backends.py
> > @@ -231,7 +231,8 @@ class ActiveDirectoryBackend(object):
> >                 for group in new_groups:
> >                     if group in old_seen:
> >                         continue
> > -                    group_data = self.search_ad(con, '(&
> > (objectClass=group)(saMAccountName=%s))' % group)
> > +                    # Search for groups with the specified DN. Use
> > the DN rather than sAMAccountName so that behavior is correct when the
> > values differ (e.g. if a "pre-Windows 2000" group name is set in AD).
> > +                    group_data = self.search_ad(con, '(&
> > (objectClass=group)(dn=%s))' % group)
> >                     seen.update(self.get_member_of(con, group_data,
> > seen=seen, depth=depth))
> >             else:
> >                 logging.warning('ActiveDirectory recursive group
> > check reached maximum recursion depth.')
>
> > Although the text "logging" is present in the diff, I don't believe
> > that this is relevant - removing "logging" from the diff does not
> > alter the error message.
>
> > I created the diff by running "git diff" in my local repository - am I
> > doing something wrong?
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to