We've done a little bit of testing with the server at VMware. There seems to
be a mix. We've had people try to dump ~1MB log files in for Description and
for Testing Done. Our Review Board admins there are beating people over the
head now to stop doing that, but given that we're seeing even that usage,
we'll need to come up with a decent limit there.
Oh, and one thing I forgot about... We store the before and after of each
field. So it's not ~50/50 for testing done and the description in the change
information. It's more like 25/25/25/25.
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Mon, Nov 23, 2009 at 11:31 AM, Chris Clark <chris.cl...@ingres.com>wrote:
> Christian Hammond wrote:
> > I don't know off-hand what we're going to set it to. We're thinking
> > about it, and suggestions are welcome. Here's where it gets tricky...
> > We're running up to maximum field lengths for the change info, and
> > that's a combination of multiple fields, including Description and
> > Testing Done. So we need to make sure that we can stuff the max of
> > both those fields, plus other change info (screenshots added, new
> > diffs, etc.).
> > The two possible solutions are to either 1) Make both Description and
> > Testing Done have a max of just under half the maximum field size for
> > the database with the smallest field restriction, or 2) Cut off the
> > text before putting it in the change description.
> > Maybe a combination of those things, in case you have both Description
> > and Testing Done at max and have added a bunch of screenshots and
> > changed other fields.
> Yikes more complicated than I thought :-( I guess in Reviewboard 3000
> the model could be changed to deal with this :-)
> For a naive solution how I about polling this mailing list for user
> input, and provide some Django manage shell scripts to get the max (and
> maybe mean, mod, median) lengths for Description and Testing fields? For
> example without checking, I'd guess that most of the reviews in my
> system have larger Description text than Testing done (most testing is
> regression test and/or a new regression test addition so the text here
> tends to be short). So armed with proof I might ask for say, 80/20 ratio
> for Description /Testing length.
> This way you get some real world numbers on lengths before you make the
> I'm lucky I've not seen this limit yet!
> Want to help the Review Board project? Donate today at
> Happy user? Let us know at http://www.reviewboard.org/users/
> To unsubscribe from this group, send email to
> For more options, visit this group at
Want to help the Review Board project? Donate today at
Happy user? Let us know at http://www.reviewboard.org/users/
To unsubscribe from this group, send email to
For more options, visit this group at