Tom is right, they should be filtered so long as Perforce has them listed as binary files.
How recent is your post-review? I'd recommend trying a nightly and seeing if the problem goes away. I seem to recall a corrupt patch issue that was fixed when using binary files, which may trigger this. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Dec 1, 2009 at 5:16 PM, Kunjal <kunjal.par...@gmail.com> wrote: > The perforce has marked them as binary file. > Why I get error message instead of some standard message saying this > is binary file or similar? > Do I need to install some patch ? > > > On Dec 1, 5:04 pm, Tom Sakkos <nasis...@gmail.com> wrote: > > Assuming that the files are marked as Binary files in Perforce, > Review-Board > > should ignore them and properly say something along the lines of "Binary > > files differ." > > > > -Tom > > > > > > > > On Tue, Dec 1, 2009 at 6:51 PM, Kunjal <kunjal.par...@gmail.com> wrote: > > > Hello, > > > > > In our development environment, we have lot of reviews only with > > > Binary files. > > > For example, If I post the review with 4 binary files, what should > > > happen when I click on View Diff? > > > > > For now, I just try with one binary file, and I get below message when > > > I click on View Diff. > > > > > Is there any work-around for binary files? > > > > > The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/usim.sbk' > > > didn't apply cleanly. The temporary files have been left in '/tmp/ > > > reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching > > > file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: **** malformed patch at > > > line 21: > > > > > Traceback (most recent call last): > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > views.py", line 153, in view_diff > > > interdiffset, highlighting, True) > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > diffutils.py", line 623, in get_diff_files > > > large_data=True) > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py", line 162, in > > > cache_memoize > > > data = lookup_callable() > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > diffutils.py", line 622, in <lambda> > > > enable_syntax_highlighting), > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > diffutils.py", line 345, in get_chunks > > > new = get_patched_file(old, filediff) > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > diffutils.py", line 261, in get_patched_file > > > return patch(filediff.diff, buffer, filediff.dest_file) > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > diffutils.py", line 129, in patch > > > (filename, tempdir, patch_output)) > > > Exception: The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/ > > > usim.sbk' didn't apply cleanly. The temporary files have been left in > > > '/tmp/reviewboard.6SzZlW' for debugging purposes. > > > `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ > > > patch: **** malformed patch at line 21: > > > > > -- > > > Want to help the Review Board project? Donate today at > > >http://www.reviewboard.org/donate/ > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > -~----------~----~----~----~------~----~------~--~--- > > > To unsubscribe from this group, send email to > > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > <reviewboard%2bunsubscr...@googlegrÂoups.com> > > > For more options, visit this group at > > >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > > > - Show quoted text - > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
