It seems that this broke at some point. I've been meaning to look into it
but haven't really had the time lately.

I believe it's due to us being a little more "smart" now with SVN diffs and
going through trying to grab info on the affected files. We need to handle
the moves/renames properly.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Dec 9, 2009 at 2:01 PM, Lyndon Washington
<hoshp...@crazy-code.com>wrote:

> Hi,
>
> Was there a resolution to the svn problem that was outlined, because I get
> a similar problem after I performed a commit that included some moved and
> deleted source files.
>
> When i try and create a review request with post-review I get the following
> error:
> Failed to execute command: ['svn', 'info',
> 'runtime/tests/src/com/notification/impl/TestNotificationMessageFactory.java']
> ['runtime/tests/src/com/notification/impl/TestNotificationMessageFactory.java:
> (Not a versioned resource)\n', '\n', 'svn: A problem occurred; see other
> errors for details\n']
>
> Cheers,
> -Lyndon-
>
> Lyndon Washington
>
>
>
>
> On Thu, Dec 3, 2009 at 11:42 AM, Jason Felice <jason.m.fel...@gmail.com>wrote:
>
>> On Thu, Dec 3, 2009 at 1:54 AM, Christian Hammond <chip...@chipx86.com>
>> wrote:
>> > Hi Jason,
>> >
>> > A standard diff -u doesn't contain the revision information needed, and
>> a
>> > git diff by default uses short SHA1s, which we can't use to fetch the
>> files.
>> > You will need to use either post-review (recommended) or git diff
>> > --full-index.
>>
>> OK, that worked.
>>
>> > post-review with Subversion should support renames and posting diffs of
>> > existing commits.
>> >
>> > What versions of Review Board and of post-review are you using?
>>
>> I tried what I got from easy_install -U RBTools, when that wouldn't
>> work, I tried git HEAD.
>>
>> My ReviewBoard install reports 1.0.5.1... weird because I thought I
>> installed the alpha because I need SVN https support, and I have
>> successfully used SVN https repositories.
>>
>> > Can you show me exactly what happens with post-review in the two cases
>> > (renames and existing commits)? You can run post-review with --debug for
>> > more information, which would help to diagnose an issue.
>>
>> C:\workspace\xpay-core>post-review --debug --revision-range 4665:4666
>> >>> svn info
>> >>> repository info: Path: https://dtvsource/svn/xpay, Base path:
>> /trunk/xpay-core-1.2, Supports changesets: False
>> >>> svn propget reviewboard:url C:\workspace\xpay-core
>> >>> svn diff --diff-cmd=diff -r 4665:4666
>> >>> svn info src/dev/testapp/emulator/nio/TaskResolver.java
>> Failed to execute command: ['svn', 'info',
>> 'src/dev/testapp/emulator/nio/TaskResolver.java']
>> ["svn: 'src\\dev\\testapp\\emulator\\nio\\TaskResolver.java' is not
>> under version control\n"]
>>
>> TaskResolver.java was renamed to EmulatorResolver.java in the named
>> commit.
>>
>>
>> By the way, I was initially confused because I didn't realize that you
>> could use post-review to do pre-commit review, might I suggest
>> renaming the tool to something like "rb-submit"?
>>
>> I tried submitting the output of svn diff, but I was sure that wasn't
>> going to work, since there isn't enough information in the diff for
>> anyone to apply it when a rename is involved!
>>
>> --
>> Want to help the Review Board project? Donate today at
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~----------~----~----~----~------~----~------~--~---
>> To unsubscribe from this group, send email to
>> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
>> For more options, visit this group at
>> http://groups.google.com/group/reviewboard?hl=en
>>
>
>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to