Thilo-Alexander Ginkel wrote:
On Friday 15 January 2010 23:20:32 Sassan wrote:
I am also thinking it might be a good idea to add a repository
independent base functionality to the post-review script where it is
handed the root directory of two source trees, before and after the
change and it will then just compare the files and post a review.

This way anyone with any source repository can just create the before
and after soure trees outside RB and pass the roots of the source
trees to the post-review script for posting.

This won't work as Review Board needs to be able to access the respective SCM repository from the server-side to apply the posted diff to the base revision.

For the server this is true. RE the client, http://reviews.reviewboard.org/r/1197/ sort of does this. It allows any diff to be sent to reviewboard .... but it had better be a valid diff :-)

Chris

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to